Sanic: Access request context globally

[cyrbil]

Flask allows to access request context instance from anywhere in the code, simply by importing flask.request. An exception is thrown when there is no context (app is starting or request is already finished).

This is no similar context proxy in sanic and it became tricky to get it when outside an handler.
One use case that we got is, being able to get the current request and add more context to the logs (url, method, ... ect) when they are created from within a request context.

One dirty workaround:

    def get_request(limit=20):
        """ sanic does not provide a globally accessible request context
             so we inspect previous frames to get one
        """
        frame = sys._getframe()
        request = None
        while frame and limit > 0:
            f_locals = frame.f_locals
            if 'request' in f_locals:
                f_request = f_locals['request']
                if isinstance(f_request, Request):
                    request = f_request
                    break
            frame = frame.f_back
            limit -= 1
        return request

[andreymal]

Global variables are crap!

[nhydock]

Duplicate of #69

[yunstanford]

I'm thinking the global request context is sort of anti-pattern. and also it's thread-local variable in Flask i guess. Sanic is async framework, which is single thread per process, if we really wanna achieve this, we have to utilize sth. like https://github.com/Skyscanner/aiotask-context.
But i don't think it's a good design to have global request context.

[cyrbil]

Agreed on the global variables crapiness ;)
I just didn't knew of alternatives, will look into aiotask-context, that may be the solution I need.

Closing this issue since its indeed a duplicate 👍