Sanic: Move sanic.utils's testing facilities to under tests namespace

[yoloseem]

sanic.utils has a dependency on aiohttp package and sanic.utils.local_request() and sanic.utils.sanic_endpoint_test() are using it. However both two functions are only accessed from test codes. aiohttp is only listed in tox.ini's deps, not requirements.txt so I think it shows that there was no intention to bring aiohttp into the main. Why don't we move sanic.utils to tests/ and just use sanic.utils name for 'real' utils needed by sanic package itself?

[kdelwat]

The problem would be that these functions are important for users in testing their own endpoints. I think it would be a shame to remove them.

[yoloseem]

Yes, not breaking users' code is crucial. But I think that it'd be better to arrange in some future, yes, some future... 😭 We can gradually deprecate them.

[seemethere]

It originally was under the test namespace but I thought it'd be useful to have it open to anyone else who needed to use it to test their own applications.

We can have this idea discussion open for a couple of weeks but my view is that we should keep it where it is (maybe rename it to something else).

[subyraman]

+1 to the idea of moving it to a separate test namespace. I can only imagine that as Sanic grows that testing utilities should be grouped in their own place.

[seemethere]

I think it would be better to have it under the application so you could use something like:

from sanic import Sanic
app = Sanic(__name__)

# add a route here

app.test_endpoint(uri, method, *request_args, **request_kwargs)

[luizberti]

Maybe do something like Flask's test_client instead of test_endpoint? It certainly comes in handy for unit testing, and it's a more idiomatic in my opinion.

[subyraman]

This issue can be closed with #431, with the next release Sanic will have a Flask-like test_client to run test requests against:

def test_index_returns_200():
    request, response = app.test_client.get('/')
    assert response.status == 200

def test_index_put_not_allowed():
    request, response = app.test_client.put('/')
    assert response.status == 405

[seemethere]

I'll allow it, closed per #431