Salt: [REGRESSION] git.latest displays errors

[tomlaredo]

Description of Issue

Version 2019.2.1 broke git.latest
Error messages are showned on git.latest :

[INFO    ] Running state [[email protected]:test/test.git] at time 11:53:54.713552
[INFO    ] Executing state git.latest for [[email protected]:test/test.git]
[INFO    ] Executing command [u'git', u'config', u'--global', u'--get-regexp', u'filter\\.lfs\\.'] in directory '/root'
[ERROR   ] Command '[u'git', u'config', u'--global', u'--get-regexp', u'filter\\.lfs\\.']' failed with return code: 1
[ERROR   ] retcode: 1

Steps to Reproduce Issue

State causing errors:

failtest-git:
    git.latest:
        - name: "[email protected]:test/test.git"
        - branch: master
        - target: /tmp/test
        - identity: {{ pillar.pkg.salt.deploy_key }}

The server and repository could exist or not, errors are displayed in both cases.

Versions Report

salt --versions-report (ON SALT MASTER)

Salt Version:
           Salt: 2019.2.1

Dependency Versions:
           cffi: Not Installed
       cherrypy: 3.5.0
       dateutil: 2.5.3
      docker-py: Not Installed
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
         Jinja2: 2.9.4
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: 0.24.0
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.4.8
   mysql-python: Not Installed
      pycparser: Not Installed
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 2.7.13 (default, Sep 26 2018, 18:42:22)
   python-gnupg: Not Installed
         PyYAML: 3.12
          PyZMQ: 16.0.2
           RAET: Not Installed
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.4.3
            ZMQ: 4.2.1

System Versions:
           dist: debian 9.11 
         locale: UTF-8
        machine: x86_64
        release: 4.15.18-9-pve
         system: Linux
        version: debian 9.11 

salt --versions-report (ON THE TEST MINION)

Salt Version:
           Salt: 2019.2.1

Dependency Versions:
           cffi: 1.9.1
       cherrypy: Not Installed
       dateutil: 2.5.3
      docker-py: Not Installed
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
         Jinja2: 2.9.4
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.4.8
   mysql-python: 1.3.7
      pycparser: 2.17
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 2.7.13 (default, Sep 26 2018, 18:42:22)
   python-gnupg: Not Installed
         PyYAML: 3.12
          PyZMQ: 16.0.2
           RAET: Not Installed
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.4.3
            ZMQ: 4.2.1

System Versions:
           dist: debian 9.11 
         locale: UTF-8
        machine: x86_64
        release: 4.15.18-15-pve
         system: Linux
        version: debian 9.11 

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[stale[bot]]

Thank you for updating this issue. It is no longer marked as stale.

[hbokh]

Also in 2019.2.2.

[c-wicklein]

I was just reviewing my private patches against 2019.2.1 and checking the associated issues here. I recall having a problem using an sls that includes git.latest when offline (salt-call on a laptop.) This is my work-around to paper over the problem...

--- states/git.py.orig  2019-09-12 11:11:55.000000000 -0500
+++ states/git.py       2019-10-04 15:52:47.635467969 -0500
@@ -710,7 +710,7 @@
     use_lfs = bool(
         __salt__['git.config_get_regexp'](
             r'filter\.lfs\.',
-            **{'global': True}))
+            **{'global': True, 'ignore_retcode': True}))  # issues/54817
     lfs_opts = {'identity': identity} if use_lfs else {}

     if os.path.isfile(target):

[Artanicus]

The fix was merged into 2019.2.1 back in October, any idea why it still haunts 3000 today? @garethgreenaway

[h3]

@Artanicus Yep... I confirm, I also have the same problem with 3000 :/

[thusoy]

Can confirm I'm also seeing this on 2019.2.3.

[Heiko-san]

can confirm it in 2019.2.4 (didn't have it in 2019.2.2)

kind of a workaround is to add the following to global .gitconfig

[filter "lfs"]
  clean = ""

[DmitryKuzmenko]

I've ported the #54844 fix to master so the regression should be fixed when it would be merged and released.