Salt: chocolatey bootstrap should support offline installation of Chocolatey itself

[ferventcoder]

Description of Issue/Question

Salt is able to bootstrap Chocolatey with chocolatey.bootstrap. However, there is nowhere to indicate an internal/offline location of the Chocolatey nupkg like you can with Chef and Puppet.

Being able to support a fully internal installation seems like a good request as other folks using Salt are using work arounds to make it happen - https://controlaltfail.wordpress.com/2017/08/03/salt-chocolatey-install-totally-offline/

Thoughts?

[ferventcoder]

cc @twangboy

Just as an FYI, I'm writing some user documentation on how to support offline installation across different configuration managers and I'm noting that it's not possible and pointing back to this issue as a placeholder until this is implemented.

[ferventcoder]

FYI here is an image of that documentation included in Chocolatey.Server v0.2.3:

[gtmanfred]

This seems like a great idea.

We would love to see a PR implementing it.

If you dont have time, @dwoz and @twangboy would yall mind taking a look and seeing if this would be quick to implement?

Thanks,
Daniel

[ferventcoder]

@gtmanfred I don't have the skills necessary to implement it. Or at least quickly and correctly.

[twangboy]

We could either add a source option to bootstrap or we could add bootstrap_local. I kind of like bootstrap_local because the bootstrap does a lot more than just install chocolatey.

• It makes sure Windows has the version of PowerShell it needs
• It installs .NET 4.0
• Then it installs Chocolatey

If we're installing chocolatey from a local source, we would need to assume that's already been done and all that's left is to install Chocolatey.

@UtahDave ?

[abmoham]

Adding input parameters seems to be an extensible method to achieving the desired result (IMHO - a better choice) and could support any of them exposed in the chef cookbook implementation @ https://github.com/chocolatey/chocolatey-cookbook/blob/master/attributes/default.rb and all the flexibility it provides.

[ferventcoder]

@twangboy I believe I agree with @abmoham on this - it feels better to have an attribute/parameter of some sort that can control where I install Chocolatey from, with a default value of the community repository (https://chocolatey.org/install.ps1 in this case). Since it is pointing to a script instead of using a local version, allow for me to pass in an alternative script that would achieve the same result.

Code at https://github.com/saltstack/salt/blob/bdcb3cb3028f759127812a3846f58cf90a0f58a8/salt/modules/chocolatey.py#L215

[twangboy]

Add source parameter to chocolatey.bootstrap. Default to https://chocolatey.org/install.ps1
Install by doing the following

• [x] Cache source from salt://, URL, or local file (similar to winrepo)
• [x] If it is a ps1 file it will run it, return success or failure
• [x] If it is a nupkg file it will unzip the file to <temp dir>
• [x] Run chocolateyInstall.ps1 from <temp dir>\tools, return success or failure

May need to do the following (may be done in the PowerShell script):

• [ ] Ensure the ChocolateyInstall environment variable is present and set to %ProgramData%\Chocolatey
• [ ] Ensure %ChocolateyInstall%\bin is in the python environment path

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.