Salt: Allow Salt to be installed anywhere in Windows
Description of Issue/Question
Programs should be installed in the Program Files directory instead of the Root of C:. We need to modify the installer to allow Salt to be installed anywhere, but default to Program files.
This would mean modifying the way the installer works:
- Add a dialog box to select a location (default to
C:\Program Files) - The python script that modifies the python, pip, and setup tools binaries will now have to be a part of the install
- Service creation will be based on the location of the Salt installation
win_verify_envwill have to be more robust, not just locking down thesaltandpkidirectories, but allowing the user to move those where they wish and have them be locked down. (currently, if they are defined in the minion config and are moved outside of the salt structure, they are not locked down.)- Put quotes around the path in the service to account for paths with spaces
41199
twangboy
All 10 comments
I think anything that needs to be locked down or cached probably needs to be separated out and default to being in %PROGRAMDATA%. This also fixes the problem of the cache being lost on upgrade (#38590) and would be the logical place to write log files and store keys (i.e. 'Program Files' is meant to be static).
morganwillcock
on 9 Aug 2017
Agreed.
markuskramerIgitt
on 13 Aug 2017
@morganwillcock the msi installer does not lose the cache on upgrade, but I agree that the cache should not be placed under 'Program Files'
markuskramerIgitt
on 13 Aug 2017
@morganwillcock The cache was being deleted specifically by the installer... I removed that line this PR.
twangboy
on 14 Aug 2017
twangboy
on 13 Nov 2017
just wondering if there were any updates on this?
shortstack
on 22 Jul 2019
Upvote.
ecapuano
on 22 Jul 2019
@twangboy @dwoz any chance this is going to be implemented in the near future? thank you!
shortstack
on 16 Aug 2019
Hello, anyone here? Same question.
glebsts
on 28 Dec 2019
It was a dealbreaker for me so a few weeks ago I customised the code that builds the Salt.exe and fixed a couple of other little issues along the way. So now I can install Salt to any directory and it seems to work fine on Windows 10 and 2016. Still need to test it on older versions which I will do soon.
When I have some time in the new year was planning to figure out how to submit a pull request to submit the changes back.
If you want to test out the .exe I could post a link to it here (only version 2019.2.2 64 bit) - though not sure if the Salt devs would be okay with that or not?
markxgold
on 31 Dec 2019
Related issues
twangboy
路
3Comments
zieba88
路
3Comments
icycle77
路
3Comments
udf2457
路
3Comments
commutecat
路
3Comments
Most helpful comment
I think anything that needs to be locked down or cached probably needs to be separated out and default to being in
%PROGRAMDATA%. This also fixes the problem of the cache being lost on upgrade (#38590) and would be the logical place to write log files and store keys (i.e. 'Program Files' is meant to be static).