Salt: Master scheduled job not recorded on the event bus

[mirceaulinic]

Description of Issue/Question

I have just note that a scheduled runner on the master, when executed, does not fire events on the bus.

To reproduce, one can add the following lines in the master config:

schedule:
  schedule_my_runner:
    function: salt.cmd
    args:
      - test.ping
    minutes: 1

Which should execute the equivalent of salt-run salt.cmd test.ping (returning True) every minute.
Looking into the salt bus (using the state.event runner), this event is not recorded, although it is executed.

[mirceaulinic]

@gtmanfred did you have a chance to look into this and see if you can reproduce? Thanks!

[gtmanfred]

Sorry @mirceaulinic we were finishing up the release today, and had other work to get to.

I hope to be able to clean up the whole bug queue tomorrow and test all of them.

Thanks for your patience.

[Ch3LL]

@mirceaulinic this is probably related to this issue https://github.com/saltstack/salt/issues/12653 It seems the scheduler currently does not send back events. Although this is a somewhat different use case as it is on the master and I would like to see if i can replicate. What version of salt are you running into this on?

[mirceaulinic]

Hi @Ch3LL - I am running 2016.11.2.

12653 looks like a very old ticket to me. What would be the requirements to get it done?

I have learnt that such kind of features do not require tremendous development work, so I am happy to come with a solution. But I would need some guidelines as I don't know where to start from.

Thanks!

[Ch3LL]

That would be awesome because that would be a great thing to have. I know that @garethgreenaway has done a lot of work in the scheduler so maybe he would have some good input as to where to get started.

[mirceaulinic]

Hi @garethgreenaway - as joined now, would you mind having a look at this issue please?
Even a pointer in the right direction would be good so I can start playing around and give it a try...
Thanks!

[garethgreenaway]

@mirceaulinic Sure. Let me spend some time looking into this.

[garethgreenaway]

@mirceaulinic Taking a quick look at this it appears to be a simple fix. We're simply not firing an event back if the job is not running on a minion. I'm working on a PR now and if possible would love a second pair of eyes/tester on it.

[mirceaulinic]

Fantastic, thank you very much @garethgreenaway!

[mirceaulinic]

I'm going to close this as it has been fixed by https://github.com/saltstack/salt/pull/41658.