Sails: Why are values normalized before "before" lifecycle callbacks

Created on 16 May 2019  路  6Comments  路  Source: balderdashy/sails

Node version: 8.16.0
Sails version _(sails)_: 1.2.1
ORM hook version _(sails-hook-orm)_: 2.1.1
DB adapter & version _(sails-mysql)_: 1.0.1


When creating a record in the database, following code executes

Model.create(initialValues);

Let's say that initialValues object has some additional attributes that Model don't have.
initialValues object is normalized (additional attributes are omitted) before lifecycle callback beforeCreate is called.

In sails v0.12 initialValues object was normalized after beforeCreate lifecycle callback, but in versions after 1.0 this has changed. Why? Now I have problems upgrading my application.

If I set schema: false in config/models.js initialValues object is not normalized. But then I have to omit additional attributes by myself otherwise, the error ER_BAD_FIELD_ERROR happens.
If I want to do this (omit additional attributes) in beforeCreate in config/models.js I can't. because I don't know which specific model is being created, so I don't know which attributes to omit.

Help is needed

helpful info or workaround mysql orm question resolved v1.x

Most helpful comment

Hi Alessy,

We have facing same issue while upgrading sails 0.12 to 1.0
You need to add extra settings:

module.exports.models.attributes.id = { type: 'string', autoIncrement: true } and

  beforeCreate: function (modelObj, next) {
    modelObj.id = uuidv4(); // generate unique id
    next();
  } 

and remove id field from model attribute.

Thanks

All 6 comments

@Alessy Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

  • look for a workaround. _(Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)_
  • tell us why this issue is important to you and your team. What are you trying to accomplish? _(Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)_
  • make sure you've provided clear instructions on how to reproduce the bug from a clean install.
  • double-check that you've provided all of the requested version and dependency information. _(Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)_
  • read the code of conduct.
  • if appropriate, ask your business to sponsor your issue. _(Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)_
  • let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. _(Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)_

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

Hi Alessy,

We have facing same issue while upgrading sails 0.12 to 1.0
You need to add extra settings:

module.exports.models.attributes.id = { type: 'string', autoIncrement: true } and

  beforeCreate: function (modelObj, next) {
    modelObj.id = uuidv4(); // generate unique id
    next();
  } 

and remove id field from model attribute.

Thanks

@RavirajKakadeGit Thanks for that! @Alessy Were you able to use this workaround?

You might also have greater success (and flexibility) with handling data formatting in your action instead. 馃憤

This workaround doesn't help me. I handle data in action now. Thanks

@Alessy So besides the workaround, going with an action has helped instead?

@johnabrams7 Yes, it helped

Was this page helpful?
0 / 5 - 0 ratings

Related issues

visitsb picture visitsb  路  4Comments

radoslavpetranov picture radoslavpetranov  路  4Comments

thomasfr picture thomasfr  路  3Comments

kesavkolla picture kesavkolla  路  4Comments

anissen picture anissen  路  3Comments