Sails: Routes with forward slashes in the target are ignored on Windows (404 is returned).

[LeeGDavis]

Sails version: 0.12.7
Node version: 6.9.0
NPM version: 3.10.8
Operating system: Win 10 Pro

---

If your route's target has a forward slash in the path to your controller it will fail to register it, if you use two back slashes it is fine. It is really very easy to reproduce.:

1. Create a new Sails project
2. Create a single controller, but put it at least one director deep.
3. Create a custom route to your controller. Example:
   'get /v1/status1': 'v1\\StatusController.index'
'get /v1/status2': 'v1/StatusController.index'

/v1/status1 route will work v1/status2 will not. It should also be noted this behaviour has only been observed on Windows so far.

It should also be noted this started happening in sails 0.12.5. In the above statement the reverse is true in regards to routes prior to 0.12.5

This also largely seems to be a duplication of #3856, but I don't think that issue is passing the communist Sailsbot issue-submission system filters, so I'm filing this here to see if it works.

[karsasmus]

You could write

'get /v1/status1': 'v1' + path.sep + 'StatusController.index'

This should work, shouldn't it?

path.sep manual

[LeeGDavis]

@karsasmus I appreciate the suggestion, but this is only a recent change in behaviour and impacts all Windows users when it was working fine previously. However on another note, If slashes need to be platform filtered this way and that is the way Sails wants to role then okay, but it seems a little silly to me.

[mikermcneil]

Thanks @karsasmus and @leegdavis - we're looking into it.

[sailsbot]

This also largely seems to be a duplication of #3856, but I don't think that issue is passing the communist Sailsbot issue-submission system filters, so I'm filing this here to see if it works.

I consider myself more of a benevolent despot, thank you very much.

[sgress454]

Okay! @mikermcneil just published a patch (version 1.0.7) to the include-all dependency in Sails which should fix this issue. To test, please re-install Sails via:

npm install sails --force

or (if you have Sails installed globally)

npm install sails -g --force

To be clear, _only_ route targets with forward slashes are supported, so after this fix this should work:

'get /v1/status2': 'v1/StatusController.index'

but there's no guarantee that this will:

'get /v1/status1': 'v1\\StatusController.index'

@LeeGDavis please give it a whirl and let us know if you can verify the fix!

[LeeGDavis]

Touché @sailsbot. We shall meet again Good Sir!

[LeeGDavis]

@sgress454 @mikermcneil Confirmed, that fix works and restores the previous functionality. Also the double backslash does not work, but that has no impact on us and I didn't work prior to this bug. Thanks for the quick turn around!

[sgress454]

👍 Thanks for following up!