Sage: node-sass fails with node v12

Created on 26 Feb 2020 · 4Comments · Source: roots/sage

[x] I've read the guidelines for Contributing to Roots Projects
[x] This request isn't a duplicate of an existing issue
[x] I've read the docs and followed them (if applicable)
[x] This is not a personal support request that should be posted on the Roots Discourse community

Description

yarn command fails in node v12

I bumped into this when building with CircleCi )default php image uses v12)

Steps to reproduce

You can check locally with docker:

sudo service docker start
docker pull circleci/php:7.3-node-browsers
docker run -it circleci/php:7.3-node-browsers /bin/bash
git clone [email protected]:roots/sage.git && cd sage
yarn

now change node-sass version in package.json to version 12 and run yarn again, it will work

Expected behavior: [What you expect to happen]

yarn to install node_modules

Actual behavior: [What actually happens]

Error with node-sass

Reproduces how often: [What percentage of the time does it reproduce?]

100%

Versions

Docker image: circleci/php:7.3-node-browsers
Node V12
node-sass ~4.9.4

Additional information

Check this compatibility chart https://www.npmjs.com/package/node-sass

Source

eduardoarandah

Most helpful comment

A quick workaround is:

Remove node_modules folder
Remove package-lock.json or yarn.lock
Remove node-sass dependency from package.json file
Run yarn | yarn install | npm install in the console
Run yarn add node-sass or npm install node-sass

This will make your project work as expected before the fix is submitted.

alonsoJS on 11 Mar 2020

🎉18

All 4 comments

A quick workaround is:

Remove node_modules folder
Remove package-lock.json or yarn.lock
Remove node-sass dependency from package.json file
Run yarn | yarn install | npm install in the console
Run yarn add node-sass or npm install node-sass

This will make your project work as expected before the fix is submitted.

alonsoJS on 11 Mar 2020

🎉18

@alonsoJS this fixed the problem for me. Is there any scope to get this fixed in the official version? Took a bit of digging before I eventually found this fix.