Rustfmt: use Failure

Created on 20 Apr 2018 · 7Comments · Source: rust-lang/rustfmt

rather than std::Error

good first issue

Source

nrc

Most helpful comment

I'd love to take this. Is the general idea to simply replace std::error with failure::Error (from https://github.com/rust-lang-nursery/failure)? Does it also include std::io::Error and other variants?

mrecachinas on 23 Apr 2018

❤1 🎉1

All 7 comments

mrecachinas on 23 Apr 2018

❤1 🎉1

I'd love to take this. Is the general idea to simply replace std::error with failure::Error

Yes, exactly. There might also be something to do at the top level where we catch errors.

Does it also include std::io::Error and other variants?

No these are the concrete error types, only the error trait is replaced. At some point these concrete errors will be hidden by failure::Error, but keep them concrete as much as possible.

nrc on 23 Apr 2018

@mrecachinas Sorry I started working on it before seeing your comment, feel free to piggy back on my PR

@nrc I was wondering if my PR is what your were looking for. It uses failure only for internal error but if you want more of the failure crate that's going to have an impact on more code.

I have tried to replace FmtResult to be std::result::Result<T, Box<Fail>> but I quickly ran into implicit conversion missing. I guess that would require a much more code change. Is that what you are expecting?

I am still playing with failures, I still need to understand few things. Feel free to give guidance.