Rust: `miri` no longer builds after rust-lang/rust#75436

Created on 12 Aug 2020 · 5Comments · Source: rust-lang/rust

Hello, this is your friendly neighborhood mergebot.
After merging PR rust-lang/rust#75436, I observed that the tool miri no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @JohnTitor, do you think you would have time to do the follow-up work?
If so, that would be great!

And nominating for compiler team prioritization.

A-miri C-bug

Source

rust-highfive

All 5 comments

Here's the fix by oli: https://github.com/rust-lang/miri/pull/1507

JohnTitor on 12 Aug 2020

It looks like the PR is merged. Should this issue be closed or are there further steps to complete until it's fully fixed?

camelid on 13 Aug 2020

It looks like the PR is merged. Should this issue be closed or are there further steps to complete until it's fully fixed?

The submodule should be updated to fix toolstate.

JohnTitor on 13 Aug 2020

👍1

Thanks! I'm trying to understand the protocol around tool breakages, so I was trying to understand why the issue wasn't yet closed :)

camelid on 13 Aug 2020

👍1

I'll get https://github.com/rust-lang/miri/pull/1504 into Miri and then submit a submodule update that will close this issue. :)

I often wait a bit after Miri is fixed before doing the submodule update, to collect more things into the same update. It's okay when Miri is missing for a few days.