Rust: Re-enable LLVM and debug assertions for slow builders

Created on 2 Apr 2019  路  7Comments  路  Source: rust-lang/rust

Disabled in a recent PR the builder is routinely hitting its 3 hour time limit, tracked at https://alexcrichton.github.io/rust-ci-timing-tracker/#series=x86_64-mingw

For a win in build times we're going to disable debug/llvm assertions on this builder, but this issue is intended to track re-enabling these if we ever get infrastructure that's a bit speedier or can better handle the slowdown.


List of all the builders where assertions were disabled:

  • x86_64-mingw
  • x86_64-msvc
  • i686-mingw-1
  • i686-gnu
  • i686-gnu-nopt
  • i686-msvc-1
  • i686-msvc-2
  • x86_64-msvc-cargo
O-windows-gnu P-medium T-infra

Most helpful comment

With GHA, we should now have capacity to do this on CI. I will be posting a PR doing so soon.

All 7 comments

For posterity, this had a pretty massive impact on CI times for the thre platforms that we disabled debug/llvm assertions for:

Screen Shot 2019-04-05 at 11 38 22 AM

(currently waiting on a potential upgrade to our appveyor builder machines, maybe happening soonish)

Much has happened - we've migrated to azure in the meantime and our builds have got even slower, but there is potential to get 4 core machines there. Until then, this is still on hold.

https://github.com/rust-lang/rust/pull/64517 also disabled LLVM assertions on the following builders:

  • i686-gnu
  • i686-gnu-nopt
  • i686-msvc-1
  • i686-msvc-2
  • x86_64-msvc-cargo

Triage: Nothing has materially changed; we still don't have the time budget to re-enable these. Perhaps when the builders gain more cores.

We'll probably want to re-enable those if we switch to GitHub Actions, as we have the time budget there.

With GHA, we should now have capacity to do this on CI. I will be posting a PR doing so soon.

Was this page helpful?
0 / 5 - 0 ratings