Rust: Tracking issue for todo! macro

Created on 18 Mar 2019  Â·  11Comments  Â·  Source: rust-lang/rust

This is a tracking issue for todo! macro.

Added in #56348. Feature gate: #![feature(todo_macro)].

When stabilizing, we should adjust documentation for unimplemented! to point towards todo!

A-macros B-unstable C-tracking-issue T-libs disposition-merge finished-final-comment-period

Most helpful comment

Anyone wants to FCP for stabilization?

I find this macro so handy I began putting #![feature(todo_macro)] everywhere.

All 11 comments

Anyone wants to FCP for stabilization?

I find this macro so handy I began putting #![feature(todo_macro)] everywhere.

cc @alexcrichton --^ ?

It's been a while -- just a ping in case this slipped through. :)

I guess we should submit stabilization PR and run FCP on that? Note that the PR needs to adjust docs for unimplemented as well. I can send the PR, but not immediately: putting out fires in rust-analyzer :D

I don’t have a strong opinion on this one, but since it landed and there doesn’t seem to be significant issues discussed since:

@rfcbot fcp merge

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged team members:

  • [x] @Amanieu
  • [ ] @Kimundi
  • [x] @SimonSapin
  • [x] @alexcrichton
  • [x] @dtolnay
  • [x] @sfackler
  • [ ] @withoutboats

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

:bell: This is now entering its final comment period, as per the review above. :bell:

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

why is this not stable wet?

@FlyingCanoe it will be stable with Rust 1.40: https://github.com/XAMPPRocky/rust/blob/relnotes-1.40.0/RELEASES.md#stabilized-apis

The stabilization PR https://github.com/rust-lang/rust/pull/61879 should have closed this issue. In fact it even landed before FCP in this thread was started…

Was this page helpful?
0 / 5 - 0 ratings