Rust-clippy: Clippy 0.0.161 fails to build on 1.22.0-nightly (0701b37d9 2017-09-18)
Hello!
I routinely install clippy as part of Janitor's base project images (see Dockerfile).
When I triggered a new build today, it failed with the following errors:
$ rustup run nightly cargo install clippy
Downloading clippy v0.0.161
Installing clippy v0.0.161
Downloading clippy_lints v0.0.161
Downloading cargo_metadata v0.2.3
Downloading pulldown-cmark v0.0.15
Downloading matches v0.1.6
Downloading quine-mc_cluskey v0.2.4
Downloading unicode-normalization v0.1.5
Downloading itertools v0.6.2
Downloading either v1.1.0
Compiling pulldown-cmark v0.0.15
Compiling unicode-normalization v0.1.5
Compiling lazy_static v0.2.8
Compiling matches v0.1.6
Compiling serde v1.0.15
Compiling bitflags v0.9.1
Compiling either v1.1.0
Compiling quine-mc_cluskey v0.2.4
Compiling semver-parser v0.7.0
Compiling unicode-xid v0.0.4
Compiling num-traits v0.1.40
Compiling dtoa v0.4.2
Compiling regex-syntax v0.4.1
Compiling itoa v0.3.4
Compiling quote v0.3.15
Compiling getopts v0.2.15
Compiling itertools v0.6.2
Compiling semver v0.6.0
Compiling synom v0.11.3
Compiling toml v0.4.5
Compiling serde_json v1.0.3
Compiling syn v0.11.11
Compiling serde_derive_internals v0.16.0
Compiling serde_derive v1.0.15
Compiling cargo_metadata v0.2.3
Compiling clippy_lints v0.0.161
error[E0308]: `if let` arms have incompatible types
--> .cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.161/src/consts.rs:297:32
|
297 | let body = if let Some(id) = self.tcx.hir.as_local_node_id(def_id) {
| ________________________________^
298 | | self.tcx.mir_const_qualif(def_id);
299 | | self.tcx.hir.body(self.tcx.hir.body_owned_by(id))
300 | | } else {
301 | | self.tcx.extern_const_body(def_id)
302 | | };
| |_____________________^ expected reference, found struct `rustc::middle::cstore::ExternConstBody`
|
= note: expected type `&rustc::hir::Body`
found type `rustc::middle::cstore::ExternConstBody<'_>`
note: `if let` arm with an incompatible type
--> .cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.161/src/consts.rs:300:28
|
300 | } else {
| ____________________________^
301 | | self.tcx.extern_const_body(def_id)
302 | | };
| |_____________________^
error[E0308]: `if let` arms have incompatible types
--> .cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.161/src/bit_mask.rs:306:32
|
306 | let body = if let Some(id) = cx.tcx.hir.as_local_node_id(l) {
| ________________________________^
307 | | cx.tcx.mir_const_qualif(def_id);
308 | | cx.tcx.hir.body(cx.tcx.hir.body_owned_by(id))
309 | | } else {
310 | | cx.tcx.extern_const_body(def_id)
311 | | };
| |_____________________^ expected reference, found struct `rustc::middle::cstore::ExternConstBody`
|
= note: expected type `&rustc::hir::Body`
found type `rustc::middle::cstore::ExternConstBody<'_>`
note: `if let` arm with an incompatible type
--> .cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.161/src/bit_mask.rs:309:28
|
309 | } else {
| ____________________________^
310 | | cx.tcx.extern_const_body(def_id)
311 | | };
| |_____________________^
error: aborting due to 2 previous errors
error: Could not compile `clippy_lints`.
warning: build failed, waiting for other jobs to finish...
error: failed to compile `clippy v0.0.161`, intermediate artifacts can be found at `/tmp/cargo-install.7eXPVwhKmYE2`
jankeromnes
All 5 comments
Looks like v0.0.162 that seems to contain the fix (35fa4429e3889cc87c2087d5faa351b5861d408c) hasn't been pushed yet to crates.io.
zetok
on 19 Sep 2017
sorry, publishing now
-Manish Goregaokar
On Tue, Sep 19, 2017 at 9:42 AM, zetok notifications@github.com wrote:
Looks like v0.0.162 that seems to contain the fix (35fa442
https://github.com/rust-lang-nursery/rust-clippy/commit/35fa4429e3889cc87c2087d5faa351b5861d408c)
hasn't been pushed yet to crates.io.—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang-nursery/rust-clippy/issues/2073#issuecomment-330599692,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABivSHnhOKxrBnkrfv5pk7Cjj3gwmWj4ks5sj-7ZgaJpZM4Pciag
.
Manishearth
on 19 Sep 2017
It looks like clippy 0.0.162 never made it to crates.io, while clippy_lints did
$ cargo info clippy clippy_lints
Crate: clippy
Version: 0.0.161
Description: A bunch of helpful lints to avoid common pitfalls in Rust
Downloads: 255642
Homepage:
Documentation:
Repository: https://github.com/rust-lang-nursery/rust-clippy
Last updated: 5 days ago
Version history:
VERSION RELEASED DOWNLOADS
0.0.161 5 days ago 980
0.0.160 6 days ago 259
0.0.159 a week ago 287
0.0.158 a week ago 944
0.0.157 2 weeks ago 1216
... use -VV to show all 156 versions
Crate: clippy_lints
Version: 0.0.162
Description: A bunch of helpful lints to avoid common pitfalls in Rust
Downloads: 175845
Homepage:
Documentation:
Repository: https://github.com/rust-lang-nursery/rust-clippy
Last updated: an hour ago
Version history:
VERSION RELEASED DOWNLOADS
0.0.162 an hour ago 3
0.0.161 5 days ago 963
0.0.160 6 days ago 258
0.0.159 a week ago 282
0.0.158 a week ago 931
... use -VV to show all 93 versions
imp
on 19 Sep 2017
Yeah my dir was dirty so it failed to publish. Will do in half an hour
On Sep 19, 2017 11:28 AM, "Cyril Plisko" notifications@github.com wrote:
It looks like clippy 0.0.162 never made it to crates.io, while
clippy_lints did$ cargo info clippy clippy_lints
Crate: clippy
Version: 0.0.161
Description: A bunch of helpful lints to avoid common pitfalls in Rust
Downloads: 255642
Homepage:
Documentation:
Repository: https://github.com/rust-lang-nursery/rust-clippy
Last updated: 5 days ago
Version history:VERSION RELEASED DOWNLOADS
0.0.161 5 days ago 980
0.0.160 6 days ago 259
0.0.159 a week ago 287
0.0.158 a week ago 944
0.0.157 2 weeks ago 1216... use -VV to show all 156 versions
Crate: clippy_lints
Version: 0.0.162
Description: A bunch of helpful lints to avoid common pitfalls in Rust
Downloads: 175845
Homepage:
Documentation:
Repository: https://github.com/rust-lang-nursery/rust-clippy
Last updated: an hour ago
Version history:VERSION RELEASED DOWNLOADS
0.0.162 an hour ago 3
0.0.161 5 days ago 963
0.0.160 6 days ago 258
0.0.159 a week ago 282
0.0.158 a week ago 931... use -VV to show all 93 versions
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang-nursery/rust-clippy/issues/2073#issuecomment-330629309,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABivSAZeMv7Ti165JmUqiZmEZz3Cpe7nks5skAfEgaJpZM4Pciag
.
Manishearth
on 19 Sep 2017
Thanks a lot! 🎉
jankeromnes
on 19 Sep 2017
Related issues
phansch
·
17Comments
Manishearth
·
20Comments
choleraehyq
·
21Comments
durka
·
17Comments
sanmai-NL
·
23Comments
Most helpful comment
sorry, publishing now
-Manish Goregaokar
On Tue, Sep 19, 2017 at 9:42 AM, zetok notifications@github.com wrote: