Rust-clippy: Suggest `x > y` over `x >= y + 1` for integers

Created on 13 Aug 2017  路  10Comments  路  Source: rust-lang/rust-clippy

Also all other combinations around comparison, and adding/subtracting 1 on either side.

A-style A-unnecessary L-lint T-middle good-first-issue hacktoberfest
Source
picture oli-obk

Most helpful comment

This should also apply to changing a..b + 1 to a..=b.

picture clarfonthey on 14 Aug 2017
👍3

All 10 comments

This should also apply to changing a..b + 1 to a..=b.

clarfonthey picture clarfonthey on 14 Aug 2017
👍3

That's still unstable, but once it becomes stable, yes, that should be linted against

oli-obk picture oli-obk on 14 Aug 2017

Now that it has been stabilized shall I have a go at implementing the second part of the lint?

Nokel81 picture Nokel81 on 20 Apr 2018

jup!

oli-obk picture oli-obk on 20 Apr 2018

yup?

Nokel81 picture Nokel81 on 20 Apr 2018

The second part is all yours

oli-obk picture oli-obk on 23 Apr 2018
👍1

shouldn't this be closed?

jens1o picture jens1o on 30 Oct 2018

It doesn't seem to be working?

https://play.rust-lang.org/?version=stable&mode=debug&edition=2015&gist=758f95d32c643687e83127c749efe9b4

oli-obk picture oli-obk on 30 Oct 2018

oh okay. Thought that you have tests for that in the pr.

jens1o picture jens1o on 30 Oct 2018

Oh yea, we do have tests. I just screwed up on the playground. This works.

oli-obk picture oli-obk on 30 Oct 2018
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

BenjaminGill-Metaswitch picture BenjaminGill-Metaswitch  路  22Comments
sanmai-NL picture sanmai-NL  路  23Comments
mikerite picture mikerite  路  17Comments
Manishearth picture Manishearth  路  26Comments
Manishearth picture Manishearth  路  18Comments