Runtime: PhysicalFileProvider should implement IDisposable correctly

Created on 1 Sep 2020  路  3Comments  路  Source: dotnet/runtime

Description

This is code in PhysicalFileProvider:

https://github.com/dotnet/runtime/blob/aa5fdab9654d74bc6274c0b5d820272c8e859621/src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFileProvider.cs#L177-L194

There are at least 3 things wrong with it:

  1. It has a finalizer, but doesn't manage any native assets.
  2. It touches managed objects during its finalizer.
  3. It doesn't call GC.SuppressFinalize when it is directly disposed.

We should correctly implement the IDisposable pattern on this class.

area-Extensions-FileSystem bug up-for-grabs
Source
picture eerhardt
👍6

Most helpful comment

Same bugs here too:
https://github.com/dotnet/runtime/blob/aa5fdab9654d74bc6274c0b5d820272c8e859621/src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFilesWatcher.cs#L231-L249

picture ericstj on 1 Sep 2020
👍3

All 3 comments

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

msftbot[bot] picture msftbot[bot] on 1 Sep 2020

Same bugs here too:
https://github.com/dotnet/runtime/blob/aa5fdab9654d74bc6274c0b5d820272c8e859621/src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFilesWatcher.cs#L231-L249

ericstj picture ericstj on 1 Sep 2020
👍3

I will prepare a PR for this

Marusyk picture Marusyk on 4 Sep 2020
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

ericstj picture ericstj  路  152Comments
galvesribeiro picture galvesribeiro  路  185Comments
ghuntley picture ghuntley  路  158Comments
morganbr picture morganbr  路  225Comments
PureKrome picture PureKrome  路  157Comments