Runtime: [browser][wasm] Move messages into the project .resx.

[kjpou1]

Static text messages need to be moved into a project .resx.

[BruceForstall]

@kjpou1 what 'area' should this issue have?

[msftbot[bot]]

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

[msftbot[bot]]

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

[Nikolay-parhimovich]

It looks like the issue is solved in https://github.com/dotnet/runtime/pull/37235

[kjpou1]

Hello Nikolay

I do not think it is solved completely. I think it was only started. Will take a look at it to see where the progress is.

Thank you for the interest in the project and hopefully contributing.

[Nikolay-parhimovich]

@kjpou1 Hi!
Could you please give more details on this issue?

[kjpou1]

Sorry for the delay Nikolay.

There are still some that did not get caught in BrowserHttpHandler

https://github.com/dotnet/runtime/blob/master/src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs#L250

and

https://github.com/dotnet/runtime/blob/master/src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs#L565

Not sure I see anymore though. Most have been caught now it seems.

We can follow how the the message for blobs were handled by using the string resource instead of literal i.e. SR.net_http_client_http_browser_baseaddress_required;

If you have any questions please do not hesitate to ask.

[Nikolay-parhimovich]

@kjpou1 Hi. I created related changes in https://github.com/dotnet/runtime/pull/43723 . Could you please check it?

[kjpou1]

closed by https://github.com/dotnet/runtime/pull/43723