Runtime: Finalize logging analyzers

Created on 20 Sep 2017  路  18Comments  路  Source: dotnet/runtime

Consider adding analyzers for DefineMessage
Reference analyzers from our projects
Decide how are they going to be shipped

/cc @glennc

area-Extensions-Logging code-analyzer enhancement

Most helpful comment

Hey, is there any chance that we could publish a preview version of the logging analyzers on NuGet? I鈥檓 totally fine with the current feature set and would just like to consume them, ideally without having to rely on a separate nightly feed.

All 18 comments

Where are these analyzers published?

Will they work on VS2015?

@pakrym, still no plans to release this?

No, not in 2.1

馃槩

@pakrym - are we shipping them in "experimental" form so that people can easily try them out? I thought I heard someone say that the other day.

Yes, we would continue to ship them in the same form they are now, but wouldn't do the same thing we did with MVC and EF analyzers (reference from packages themselves)

I think these analyzers should be a little more extensive than they are now. It would also be great if they supported structured logging templates. The structured message analyzer rule can be 'none' severity by default and only enabled if users want them.

any updates on this?

@pakrym any updates on this one? can you please point me to the current nuget feed used for nightly builds? I didnt find any info on this in the readme and the link above does not work (vs shows no packages) and the link to the package asks for credentials.

@anurse might have more information on this.

I believe the packages should be on the dotnet-core nightly feed: https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json

I don't have specific updates on the progress here, but it will be considered as part of 5.0 planning.

Could this tie in to the analyzer effort you're working on @bartonjs @jeffhandley ? These are analyzers currently produced in extensions (though the logging stuff is now owned by the runtime) that we don't currently ship (they're marked as non-shipping packages) but would be useful for anyone using Microsoft.Extensions.Logging.

Hey @anurse - sorry for the delayed response. Our review process is currently fairly narrow as we were only planning to ship a small set of analyzers for now and dial it up later, and I don't expect we'll add any more analyzers into the .NET Libraries team's backlog for 5.0. Were you just thinking you want to get these into the backlog, or did you want to contribute them into a productized shipping vehicle?

Would this issue be at all related to https://github.com/Suchiman/SerilogAnalyzer/issues/15 ?

Hey, is there any chance that we could publish a preview version of the logging analyzers on NuGet? I鈥檓 totally fine with the current feature set and would just like to consume them, ideally without having to rely on a separate nightly feed.

cc @davidfowl @ericstj @tarekgh

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jzabroski picture jzabroski  路  3Comments

Timovzl picture Timovzl  路  3Comments

matty-hall picture matty-hall  路  3Comments

jkotas picture jkotas  路  3Comments

noahfalk picture noahfalk  路  3Comments