Runtime: Consolidate files which were split by tfms which aren't supported anymore

[ViktorHofer]

In example ProcessTests.netcoreapp.cs should be consolidated with ProcessTests.cs. As we just removed UWP we have multiple places to clean-up.

cc @stephentoub

[Marusyk]

Please assign it to me

[ViktorHofer]

Thanks for helping, assigned. Let me know if you need any help.

[Marusyk]

Could you please clarify if I should consolidate other netcoreapp.cs files

[Marusyk]

I continue to work on this to combine other files

[ViktorHofer]

yes, this issue isn't just about the ProcessTests file but also about others which were split by the target framework which isn't necessary anymore as the project doesn't multi-target anymore.

[Marusyk]

So, can I continue in dotnet/runtime?

[ViktorHofer]

yes :)

[Marusyk]

Well, it's almost done, but a few questions.

I shouldn't remove *.netcoreapp.cs files for projects where BuildConfigurations has $(NetFrameworkCurrent); , right?

• Microsoft.CSharp
• System.ComponentModel.Annotations
• System.ServiceModel.Syndication
• System.Threading.Channels
• System.Security.Cryptography.Pkcs

And finally, the GenericVectorTests.netcoreapp.cs from System.Numerics.Vectors with GenericVectorTests.netcoreapp.tt, should it be consolidated with GenericVectorTests.cs and GenericVectorTests.tt?

[jkotas]

Yes, you are right for both of these.

[Marusyk]

Thank you all for these reviews.
It looks like done. Please let me know if I missed something, otherwise the issue can be closed.

[jkotas]

Thank you a lot for all your work on this!

[ViktorHofer]

Indeed, thanks a lot for your dedication here.