Runtime: Incorrect testhost configuration for source-build

[adaggarwal]

Environment - CentOS docker on RHEL7 Hyper-V vm.
CoreFX version - 1bb52e6a3db7f3673a3825f3677b9f27b9af99aa
Sourcebuild PR

Details:
The testhost that gets cooked up in sourcebuild->corefx->artifacts has a faulty System.Memory.dll when compared to the one in standalone corefx. This results in test run failures for source-build corefx tests. It seems to be a configuration issue.

Steps to repro:

1. Use source-build clone for the commit SHA1 aforementioned. And build.sh for a primary build.
2. For setting up test utilities and running the tests; build again with test flag, i.e. build.sh -test

[Extra Steps to validate the erroneous dll] ->

1. Build a standalone corefx using the commit SHA1 mentioned and copy System.Memory.dll from shared testhost to SB/bin/src/corefx./artifacts/bin/testhost/<>/<>/shared/.
2. Manually run any of the tests which were failing previously in source-build test build.

[adaggarwal]

cc @ericstj @joperezr @crummel

[ericstj]

This is the same as https://github.com/dotnet/corefx/pull/40199. @adaggarwal did you try porting that fix to source build?

[adaggarwal]

Thanks for the pointer @ericstj

[eerhardt]

did you try porting that fix to source build?

@ericstj - looking at the fix for dotnet/corefx#40199, I don't even see those files in the release/3.0 branch. Is that expected?

EDIT: I see now that those files were moved in dotnet/corefx#40066. We should be able to port the changes to the external folder.

@ericstj - were you planning on porting that change to 3.0?

[ericstj]

@ericstj - were you planning on porting that change to 3.0?

@eerhardt yep. FYI, git did a clean cherry-pick here despite the move. GIT ≫ GitHub. 😝

[adaggarwal]

@ericstj @eerhardt While the dotnet/corefx#40426 is in CI, I tried the changes in my local via a coreFX patch and it works! :)