Runtime: Improve test coverage of Span.SequenceCompareTo for T != byte

Created on 15 Mar 2018  路  7Comments  路  Source: dotnet/runtime

We need to add more tests for MemoryExtensions SequenceCompareTo for T = int, long, string, etc.

For context - https://github.com/dotnet/corefx/pull/28080#discussion_r174811155

area-System.Memory easy increase-code-coverage

All 7 comments

I'd be glad to start contributing to corefx with this one !

I'd be glad to start contributing to corefx with this one !

Awesome! Let me know if you have any questions regarding on-boarding or contributing.

@karelz, can we please assign this issue to @sputier?

@sputier I just sent you collaborator invite (GH prereq to assign it to you). Once you accept ping me and I will reassign it to you (assigning to myself temporarily).
Heads up: Accepting will auto-subscribe you to all repo notifications (500+ per day). We recommend to change repo Watch settings to "Not Watching" - that will notify you only about your mentions and explicit subscriptions.

@ahsonkhan @karelz Thank you ! I accepted the invite, and I'm ready to dig into corefx :smile:

@sputier, we would like to fix all ship stopping bugs by end of week so they have time go through PR review / CI. Is that something you'd still want to tackle?

I'm working on it at the moment and I'll make a PR tomorrow (3PM PT or so). Is it OK for you ?

Perfect. Thanks for confirming so quickly!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jzabroski picture jzabroski  路  3Comments

v0l picture v0l  路  3Comments

matty-hall picture matty-hall  路  3Comments

jkotas picture jkotas  路  3Comments

GitAntoinee picture GitAntoinee  路  3Comments