Runtime: Improve code coverage for ReadOnlySequence and BuffersExtensions

[pakrym]

• [x] BuffersExtensions - code coverage is at 70%
• [ ] ReadOnlySequence - (coverage at ~93%) - Add tests for longer than int.Max

Edited by @ahsonkhan

[ahsonkhan]

From https://github.com/dotnet/corefx/pull/26694#issuecomment-362620565

Also see: https://github.com/dotnet/corefxlab/pull/2111#discussion_r167385136

[ahsonkhan]

Also, BuffersExtensions code coverage is at 70% - we need to get that coverage up. See https://github.com/dotnet/corefx/pull/27691#issuecomment-370190023

[benaadams]

Memory Coverage report https://aoa.blob.core.windows.net/aspnet/memory-coverage.zip

[muratg]

@joshfree We won't have time to get this done during preview2.

Let's reassign it back to @pakrym after preview2.

[AlexRadch]

I started to add ReadOnlySequence tests for longer than int.Max

[ahsonkhan]

If you want to see missing code coverage areas, run msbuild /t:rebuildandtest /p:Coverage=true from the System.Memory test directory and navigate to/open \corefx\bin\tests\coverage\System.Memory_ReadOnlySequence_1.htm

In BufferExtensions, public static void Write<T>(this System.Buffers.IBufferWriter<T> bufferWriter, ReadOnlySpan<T> source) (and WriteMultiSegment) need some test coverage.

[joshfree]

@muratg can we reconsider this for preview2 given that ROS doesn't have good test coverage on corner cases and the most recent test PR did uncover a nasty bug?

[muratg]

@joshfree Unfortunately, I don't think anyone from my side will be able to pick this up in the next few weeks.

[AlexRadch]

@joshfree I wrote before that I started to Add tests for ReadOnlySequence longer than int.Max

But I was interrupted by issue in ReadOnlySequence https://github.com/dotnet/corefx/pull/28095. Now it is fixed https://github.com/dotnet/corefx/pull/28294.
Also now I am fixing those issues https://github.com/dotnet/corefx/issues/28136. So when I am complete with this I will finish ReadOnlySequence longer than int.Max tests.

[wilka]

I'd like to take a look at this one for the Hackathon.

[ViktorHofer]

I sent you an collaboration invite. Please accept so I can assign you to the issue.

[wilka]

@AlexRadch did you finish your ReadOnlySequence longer than int.Max tests? If not, I can take a look at that part as well.

[pjanotti]

Latest numbers: