Runtime: building/windows-instructions.md docs need update

[caesar-chen]

https://github.com/dotnet/corefx/blob/master/Documentation/building/windows-instructions.md

Under Required Software -> For Visual Studio 2017, there is a very important component missing:
we need to have .NET Core cross-platform development checked as well (Workloads -> Other Toolsets)

And there is a issue blocking me for two days, starting from Monday. If I pull from dotnet master, then do "clean.cmd" (or any other commands), it has the error message: "System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime.Serialization.Primitives, Version=4.1.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a". However, if I reverted to a commit in last Friday, then everything is working.

@davidsh found out that my VS2017 is missing some components, and after adding many things, the error message goes away.

I'm not sure what' the minimum requirements for VS2017 (the ones in windows-instructions.md are not enough). I attached my configuration. For now, it works for me.

[danmosemsft]

@caesar1995 would you consider fixing the doc, at least in part?

For the error, I would do "git clean -fdx" and then build from root.

[caesar-chen]

@danmosemsft I tried to delete my local repo and do a new fork followed by a clone, the problem still existed. After I installed some VS2017 components, the error goes way though.

I will fix part of the doc to include .NET Core cross-platform development.

[hughbe]

I had this exact issue yesterday. Cleaning didn't work, reckoning didn't work. Note that I have the right VS components installed.

The fix is to enable RemoteSigned execution policy in powershell. This seems like a recent build tools regression

[davidsh]

The fix is to enable RemoteSigned execution policy in powershell.

Set-ExecutionPolicy RemoteSigned

[karelz]

Is it something that should be captured also in new contrib docs?

[caesar-chen]

@karelz I think so. At least in this document: https://github.com/dotnet/corefx/wiki/Development-environment-setup-for-Windows we need to include .NET Core cross-platform development for 'Workloads' based install. Do you want me to add it?

[karelz]

Yes, please. Make the edits. It is wiki - RW for everyone, incl. contributors. We will change the content after-the-fact if we don't like it :)

[caesar-chen]

The .NET Core cross-platform development has been included in Workloads based install in Wiki.

Since there is no other people hitting this issue from June 2017, I will close it.

/cc: @karelz