Runtime: sync.cmd / build.cmd commandlets fail when a space is in the path

[FransBouma]

I know, why on earth would you use a space a file path, but I happen to have the path: \myprojects\vs.net projects\github\corefx which makes sync.cmd and build.cmd fail as they don't wrap the path they're in with quotes.

Moving the repo on disk to a folder without a space solves it. Not a high-prio error, just a FYI in case you didn't know. The https://github.com/dotnet/corefx/wiki/Checking-out-the-code-repository page would likely benefit from a warning in this case, so people who clone the repo and try to build it aren't surprised if they're as daft as me and use a space in the path their cloned repo is located ;)

[garfbradaz]

I had the same thing. Example, I use Box, and you will have a directory structure

C:\Users\me\Box Sync\corefx

Again I moved to root of C: with no spaces and works.

[karelz]

Thanks for catching it @FransBouma! I updated the wiki page. Next time, feel free to make the edits as well - it is RW for everyone and bunch of us are partying on the wiki, collaborating in a gitter room ...

[FransBouma]

@karelz thanks, will update the wiki next time and pop in the gitter room :)

[ViktorHofer]

@weshaggard I didn't check, do you think that's still happening?

[weshaggard]

There is likely a good chance it still happens unless someone explicitly fixed it. However with the engineering system changes coming sync will no longer exist as a separate script and build will be going through a new pipeline which hopefully handles this a little better. It is worth verifying that build works correctly with spaces in the repo path.

[wtgodbe]

Build still fails from a path with a space in it.