Runtime: Improve code coverage for System.Xml.Schema

[sepidehkh]

These are some of the bigger types with low coverage in System.Xml.Schema. It would be great if we could add more tests to reach 80-90% coverage on these (data updated on 2017/12/11):

• [ ] System.Xml.Schema.XmlAtomicValue 36.7% (was 33.7% originally)
• [ ] System.Xml.Schema.XmlSchemaAny 36.5%
• [ ] System.Xml.Schema.XmlSchemaAnyAttribute 74.5% (was 36.3% originally, see dotnet/corefx#22020)
• [ ] System.Xml.Schema.XmlSchemaCollection 42.6%
• [ ] System.Xml.Schema.XmlSchemaInference 17.8%

Detailed coverage report:
https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows/Code_Coverage_Report/

[danmosemsft]

Info on code coverage work:

1) Here's the all up report
https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows/Code_Coverage_Report/
Caveat - doesn't show coverage of any types whose implementation is in corelib (eg String, etc). If you want to look at that for now you must gather manually using instructions below.

2) Docs on code coverage work are here
https://github.com/dotnet/corefx/blob/master/Documentation/building/code-coverage.md
and some in
https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/developer-guide.md

3) There's innumerable places to add coverage -- we would love to focus on the most heavily used types and the least covered types to get the most benefit.

[ilya-bin]

Hi @sepidehMS ,
I'd like to participate in the issue but never did opensource before.
I've just read all the related docs and style guides.

[sepidehkh]

@ilya-bin Thank you for your interest in helping with this issue :)
All the existing tests for System.Xml.Schema are here. You can add new tests under any of these two test projects or create a new test project, if that makes more sense, based on what the test is doing. You can find the information on what cases need to be covered from the links on this issue. After you write the new tests, you can submit a Pull Request and we will review your changes and help you get a clean build. After that, your changes can be merged.
Feel free to assign this issue to yourself and don't hesitate to ask if you had any questions.

[ilya-bin]

Dear @sepidehMS
I am moving on with the assignment (prepared environment, forked, built etc) but due to my poor experience I have some issues.

1. I am not quite understand the tests projects structure. I see that XmlSchema covered for about 70% and Read() and Write() methods coverage would be effective. But I am not sure how to start, I am not seeing the corresponding XmlSchema test project. Porbably my approach to the projects structure is not quite right. Could you please assist me.

2. This is just a formality about issue assignment. I am not sure I have the permissions to assign myself or anyone else.

[karelz]

@ilya-bin happy to hear that you want to contribute! I just sent you Collaborator invite. Once you accept, we will be able to assign the issue to you. Please ping us, when you accept.

Assigning temporarily to @sepidehMS.

Also note that we have contributor docs under construction, please feel free to make them better - they are on wiki, which is RW for everyone: https://github.com/dotnet/corefx/wiki/New-contributor-Docs
There's also new gitter chat room for new contributor docs if you want to ask questions others, and you can always ping us on the issue for help if you hit any road blocks. Thanks!

[sepidehkh]

@ilya-bin
The XmlSchema tests live in these two projects:

• System.Xml.XmlSchemaSet.Tests
• System.Xml.XmlSchemaValidatorApi.Tests.

You can take a look at the existing tests for the structure. About code coverage, the code blocks highlighted in red show the lines that are not covered by the existing tests, so we need to add scenarios that would hit those blocks.
Although any improvement in terms of coverage is appreciated, for this issue in particular we are more interested in improving code coverage for the types mentioned in this issue's first comment. Those are the ones that are least covered by our tests.

I hope this answered your question. Let me know if you needed anything.

[ilya-bin]

Hi @karelz
Thanks for the invite just accepted it.
@sepidehMS
Thank you for the answer, I'll try to move on now, is it okay to ping you for the advice here in the issue comments, or should I use gitter instead?

[sepidehkh]

@ilya-bin Please post your questions here and mention me. I just assigned the issue to you.

[ilya-bin]

Hi @sepidehMS ,
I've tried to find anything in the test cases that is actually not so complicated for me and the place where it could be helpful. The case is that every straightforward public method in XmlSchemaSet is already covered with unit tests (which is actually good) and the lines that are not covered are hard for me. :)

I think I've found a 3 line style enhancement that could be useful, please review PR dotnet/corefx#20115 if it could be helpful in any way.

Thanks.

[sepidehkh]

@ilya-bin That is fine. I will remove your assignment on this issue then. If you like to contribute, you can look for other up-for-grabs issues :) Thank you.

[ilya-bin]

@sepidehMS Thank you.

[lukmatyja]

Hi @sepidehMS ,
I'm first time contributor. I'd like to add some tests to listed classes. May I?

[karelz]

@supporterPL sure thing. I sent you Collaborator invite to the repo. Please ping us here once you accept and we will be able to assign it to you. (cc @pjanotti @danmosemsft)
Temporarily assigning to myself.

Pro tip: Disable CoreFX repo notifications. There is 300+ daily, it feels like DoS on your email server. Subscribe to just your 'mentions' notifications.

If you need help, don't hesitate to ask. We have also docs on wiki for new contributors. Wiki is R/W for everyone, so feel free to improve the docs if you want to.
Welcome onboard!

[lukmatyja]

@karelz I've just accepted invitation.

[lukmatyja]

@karelz i've just created PR (#22020). Please look if it is ok for you. Thanks.

[isiahto]

Hello, I was going to contribute to the ComponentModel.TypeConverter test coverage, then I saw @danmosemsft message so I hopped over here.
I was able to build the TypeConverter project and make changes to the tests and all that, but I cannot build the System.Private.Xml project to begin with.

To add some context, I have built the runtime using .\build.cmd clr+libs -rc checked -lc release
Then I dived into the System.Private.Xml.sln and tried building it, then I got the following:

Build started...
1>------ Build started: Project: System.Private.Xml, Configuration: Debug Any CPU ------
2>------ Build started: Project: TestUtilities, Configuration: Debug Any CPU ------
1>System.Private.Xml -> C:\Users\Isiah\Documents\Repositories\isiahto-runtime\artifacts\bin\System.Private.Xml\net5.0-Windows_NT-Debug\System.Private.Xml.dll
1>System.Private.Xml -> C:\Users\Isiah\Documents\Repositories\isiahto-runtime\artifacts\bin\System.Private.Xml\net5.0-Debug\System.Private.Xml.dll
3>------ Build started: Project: System.Xml.RW.XmlReaderLib, Configuration: Debug Any CPU ------
2>CSC : error CS0006: Metadata file 'C:\Users\Isiah\Documents\Repositories\isiahto-runtime\artifacts\bin\System.Runtime.CompilerServices.Unsafe\net45-Debug\System.Runtime.CompilerServices.Unsafe.dll' could not be found
2>Done building project "TestUtilities.csproj" -- FAILED.
2>TestUtilities -> C:\Users\Isiah\Documents\Repositories\isiahto-runtime\artifacts\bin\TestUtilities\net5.0-Debug\TestUtilities.dll
4>------ Build started: Project: System.Xml.Misc.Tests, Configuration: Debug Any CPU ------
5>------ Build started: Project: System.Xml.RW.RwFactory.Tests, Configuration: Debug Any CPU ------
6>------ Build started: Project: System.Xml.RW.XmlWriterApi.Tests, Configuration: Debug Any CPU ------
3>CSC : error CS0006: Metadata file 'C:\Users\Isiah\Documents\Repositories\isiahto-runtime\artifacts\bin\ModuleCore\netstandard2.0-Debug\ModuleCore.dll' could not be found
3>CSC : error CS0006: Metadata file 'C:\Users\Isiah\Documents\Repositories\isiahto-runtime\artifacts\bin\XmlCoreTest\net5.0-Debug\XmlCoreTest.dll' could not be found
3>CSC : error CS0006: Metadata file 'C:\Users\Isiah\Documents\Repositories\isiahto-runtime\artifacts\bin\XmlDiff\netstandard2.0-Debug\XmlDiff.dll' could not be found
3>Done building project "System.Xml.RW.XmlReaderLib.csproj" -- FAILED.
... all other test projects failed too....

I did a search from the root I couldn't find anything related to ModuleCore. As for the net45-debug\CompilerServices.Unsafe.dll, did I miss building something platform specific for the dll?

[danmosemsft]

@krwq could you please help @isiahto here? If there's any bugs in our VS build experience, let's get isuses opened.

[krwq]

@isiahto I usually use build -subset clr+libs -runtimeConfiguration Release from Developer Command Prompt (make sure to clean repo if you're seeing random errors, i.e. git clean -fdx) and then build src\libraries\System.Private.Xml\src directory.
I'll now try the configuration you're using and see if there is any difference. To answer the question about ModuleCore it can be found here:
https://github.com/dotnet/runtime/blob/master/src/libraries/Common/tests/System/Xml/ModuleCore/ModuleCore.csproj

EDIT:
I've just tried and both System.Private.Xml src and sln building the same way as you did and I can build both successfully with dotnet build.

If you're using VS for building you might need to start VS while being in the root of the repo with build -vs System.Private.Xml - it will ensure it uses the right tooling

[isiahto]

@krwq All I had to do was to run dotnet build in command prompt, then open up VS and build the solution.
I tried my previous runtime build command and your usual, both builds the solution just fine as long as dotnet build is called beforehand.
Thanks for the help I am able to build and run the project and tests now!

[krwq]

Glad to head @isiahto! @ViktorHofer is this something we can quickly fix? (making sure that running tests is building first)

[ViktorHofer]

Building is an implicit action when testing, both inside vs and on the cli. Is that what you meant?

[krwq]

@isiahto can you expand on how did you get the errors above?

[isiahto]

I did the following steps on my computer, just to be sure, I spun up an Win10 VM, had Python3, CMake and VS 19 Preview installed and able to reproduce.
Steps:

1. Clone project
2. Build project at root with: build -subset clr+libs -runtimeConfiguration Release
3. Launch the solution in \runtime\src\libraries\System.Private.Xml
4. Restore NuGet Packages at solution level gives me an error:
   Error occurred while restoring NuGet packages: Invalid restore input. Duplicate frameworks found: 'net5.0, net5.0'. Input files: C:\Users\isiah\github\runtime\src\libraries\System.Private.Xml\src\System.Private.Xml.csproj.
5. Open Powershell and dotnet restore at the solution folder
6. After restore completed, back to VS and build solution, then the build failed with:

Build Log:

Build started...
1>------ Build started: Project: System.Private.Xml, Configuration: Debug Any CPU ------
2>------ Build started: Project: TestUtilities, Configuration: Debug Any CPU ------
Error occurred while restoring NuGet packages: Invalid restore input. Duplicate frameworks found: 'net5.0, net5.0'. Input files: C:\Users\isiah\github\runtime\src\libraries\System.Private.Xml\src\System.Private.Xml.csproj.
1>System.Private.Xml -> C:\Users\isiah\github\runtime\artifacts\bin\System.Private.Xml\net5.0-Debug\System.Private.Xml.dll
2>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\System.Runtime.CompilerServices.Unsafe\net45-Debug\System.Runtime.CompilerServices.Unsafe.dll' could not be found
2>Done building project "TestUtilities.csproj" -- FAILED.
2>TestUtilities -> C:\Users\isiah\github\runtime\artifacts\bin\TestUtilities\net5.0-Debug\TestUtilities.dll
1>System.Private.Xml -> C:\Users\isiah\github\runtime\artifacts\bin\System.Private.Xml\net5.0-Windows_NT-Debug\System.Private.Xml.dll
3>------ Build started: Project: System.Xml.RW.XmlReaderLib, Configuration: Debug Any CPU ------
4>------ Build started: Project: System.Xml.Misc.Tests, Configuration: Debug Any CPU ------
3>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\ModuleCore\netstandard2.0-Debug\ModuleCore.dll' could not be found
3>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlCoreTest\net5.0-Debug\XmlCoreTest.dll' could not be found
3>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlDiff\netstandard2.0-Debug\XmlDiff.dll' could not be found
3>Done building project "System.Xml.RW.XmlReaderLib.csproj" -- FAILED.
5>------ Build started: Project: System.Xml.RW.CharCheckingReader.Tests, Configuration: Debug Any CPU ------
4>System.Xml.Misc.Tests -> C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.Misc.Tests\net5.0-Debug\System.Xml.Misc.Tests.dll
6>------ Build started: Project: System.Xml.RW.CustomReader.Tests, Configuration: Debug Any CPU ------
6>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\ModuleCore\netstandard2.0-Debug\ModuleCore.dll' could not be found
6>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.RW.XmlReaderLib\net5.0-Debug\System.Xml.RW.XmlReaderLib.dll' could not be found
6>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlCoreTest\net5.0-Debug\XmlCoreTest.dll' could not be found
6>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlDiff\netstandard2.0-Debug\XmlDiff.dll' could not be found
6>Done building project "System.Xml.RW.CustomReader.Tests.csproj" -- FAILED.
7>------ Build started: Project: System.Xml.RW.FactoryReader.Tests, Configuration: Debug Any CPU ------
5>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\ModuleCore\netstandard2.0-Debug\ModuleCore.dll' could not be found
5>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.RW.XmlReaderLib\net5.0-Debug\System.Xml.RW.XmlReaderLib.dll' could not be found
5>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlCoreTest\net5.0-Debug\XmlCoreTest.dll' could not be found
5>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlDiff\netstandard2.0-Debug\XmlDiff.dll' could not be found
5>Done building project "System.Xml.RW.CharCheckingReader.Tests.csproj" -- FAILED.
8>------ Build started: Project: System.Xml.RW.NameTable.Tests, Configuration: Debug Any CPU ------
7>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\ModuleCore\netstandard2.0-Debug\ModuleCore.dll' could not be found
7>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.RW.XmlReaderLib\net5.0-Debug\System.Xml.RW.XmlReaderLib.dll' could not be found
7>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlCoreTest\net5.0-Debug\XmlCoreTest.dll' could not be found
7>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlDiff\netstandard2.0-Debug\XmlDiff.dll' could not be found
7>Done building project "System.Xml.RW.FactoryReader.Tests.csproj" -- FAILED.
9>------ Build started: Project: System.Xml.RW.ReaderSettings.Tests, Configuration: Debug Any CPU ------
8>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\ModuleCore\netstandard2.0-Debug\ModuleCore.dll' could not be found
8>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.RW.XmlReaderLib\net5.0-Debug\System.Xml.RW.XmlReaderLib.dll' could not be found
8>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlCoreTest\net5.0-Debug\XmlCoreTest.dll' could not be found
8>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlDiff\netstandard2.0-Debug\XmlDiff.dll' could not be found
8>Done building project "System.Xml.RW.NameTable.Tests.csproj" -- FAILED.
10>------ Build started: Project: System.Xml.RW.SubtreeReader.Tests, Configuration: Debug Any CPU ------
9>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\BaseLibManaged\netstandard2.0-Debug\BaseLibManaged.dll' could not be found
9>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\ModuleCore\netstandard2.0-Debug\ModuleCore.dll' could not be found
9>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.RW.XmlReaderLib\net5.0-Debug\System.Xml.RW.XmlReaderLib.dll' could not be found
9>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlCoreTest\net5.0-Debug\XmlCoreTest.dll' could not be found
9>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlDiff\netstandard2.0-Debug\XmlDiff.dll' could not be found
9>Done building project "System.Xml.RW.ReaderSettings.Tests.csproj" -- FAILED.
11>------ Build started: Project: System.Xml.RW.WrappedReader.Tests, Configuration: Debug Any CPU ------
10>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\ModuleCore\netstandard2.0-Debug\ModuleCore.dll' could not be found
10>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.RW.XmlReaderLib\net5.0-Debug\System.Xml.RW.XmlReaderLib.dll' could not be found
10>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlCoreTest\net5.0-Debug\XmlCoreTest.dll' could not be found
10>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlDiff\netstandard2.0-Debug\XmlDiff.dll' could not be found
10>Done building project "System.Xml.RW.SubtreeReader.Tests.csproj" -- FAILED.
12>------ Build started: Project: System.Xml.RW.RwFactory.Tests, Configuration: Debug Any CPU ------
11>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\ModuleCore\netstandard2.0-Debug\ModuleCore.dll' could not be found
11>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.RW.XmlReaderLib\net5.0-Debug\System.Xml.RW.XmlReaderLib.dll' could not be found
11>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlCoreTest\net5.0-Debug\XmlCoreTest.dll' could not be found
11>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlDiff\netstandard2.0-Debug\XmlDiff.dll' could not be found
11>Done building project "System.Xml.RW.WrappedReader.Tests.csproj" -- FAILED.
13>------ Build started: Project: System.Xml.RW.XmlWriterApi.Tests, Configuration: Debug Any CPU ------
12>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\ModuleCore\netstandard2.0-Debug\ModuleCore.dll' could not be found
12>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlCoreTest\net5.0-Debug\XmlCoreTest.dll' could not be found
12>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlDiff\netstandard2.0-Debug\XmlDiff.dll' could not be found
12>Done building project "System.Xml.RW.RwFactory.Tests.csproj" -- FAILED.
14>------ Build started: Project: System.Xml.RW.XmlConvert.Tests, Configuration: Debug Any CPU ------
13>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\ModuleCore\netstandard2.0-Debug\ModuleCore.dll' could not be found
13>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlCoreTest\net5.0-Debug\XmlCoreTest.dll' could not be found
13>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlDiff\netstandard2.0-Debug\XmlDiff.dll' could not be found
13>Done building project "System.Xml.RW.XmlWriterApi.Tests.csproj" -- FAILED.
15>------ Build started: Project: System.Xml.XmlDocument.Tests, Configuration: Debug Any CPU ------
14>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\ModuleCore\netstandard2.0-Debug\ModuleCore.dll' could not be found
14>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlCoreTest\net5.0-Debug\XmlCoreTest.dll' could not be found
14>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlDiff\netstandard2.0-Debug\XmlDiff.dll' could not be found
14>Done building project "System.Xml.RW.XmlConvert.Tests.csproj" -- FAILED.
16>------ Build started: Project: System.Xml.XmlNodeReader.Tests, Configuration: Debug Any CPU ------
15>System.Xml.XmlDocument.Tests -> C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.XmlDocument.Tests\net5.0-Debug\System.Xml.XmlDocument.Tests.dll
17>------ Build started: Project: System.Xml.RW.XmlReader.ReadContentAs.Tests, Configuration: Debug Any CPU ------
16>System.Xml.XmlNodeReader.Tests -> C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.XmlNodeReader.Tests\net5.0-Debug\System.Xml.XmlNodeReader.Tests.dll
18>------ Build started: Project: System.Xml.RW.XmlReader.Tests, Configuration: Debug Any CPU ------
18>System.Xml.RW.XmlReader.Tests -> C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.RW.XmlReader.Tests\net5.0-Debug\System.Xml.RW.XmlReader.Tests.dll
19>------ Build started: Project: System.Xml.RW.XmlSystemPathResolver.Tests, Configuration: Debug Any CPU ------
17>System.Xml.RW.XmlReader.ReadContentAs.Tests -> C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.RW.XmlReader.ReadContentAs.Tests\net5.0-Debug\System.Xml.RW.XmlReader.ReadContentAs.Tests.dll
20>------ Build started: Project: System.Xml.XmlResolver.Tests, Configuration: Debug Any CPU ------
19>System.Xml.RW.XmlSystemPathResolver.Tests -> C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.RW.XmlSystemPathResolver.Tests\net5.0-Debug\System.Xml.RW.XmlSystemPathResolver.Tests.dll
21>------ Build started: Project: System.Xml.XmlSchemaSet.Tests, Configuration: Debug Any CPU ------
20>System.Xml.XmlResolver.Tests -> C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.XmlResolver.Tests\net5.0-Debug\System.Xml.XmlResolver.Tests.dll
22>------ Build started: Project: System.Xml.XmlSchema.XmlSchemaValidatorApi.Tests, Configuration: Debug Any CPU ------
22>System.Xml.XmlSchema.XmlSchemaValidatorApi.Tests -> C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.XmlSchema.XmlSchemaValidatorApi.Tests\net5.0-Debug\System.Xml.XmlSchema.XmlSchemaValidatorApi.Tests.dll
23>------ Build started: Project: System.Xml.XmlSerializer.ReflectionOnly.Tests, Configuration: Debug Any CPU ------
21>System.Xml.XmlSchemaSet.Tests -> C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.XmlSchemaSet.Tests\net5.0-Debug\System.Xml.XmlSchemaSet.Tests.dll
24>------ Build started: Project: System.Xml.XmlSerializer.Tests, Configuration: Debug Any CPU ------
23>System.Xml.XmlSerializer.ReflectionOnly.Tests -> C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.XmlSerializer.ReflectionOnly.Tests\net5.0-Debug\System.Xml.XmlSerializer.ReflectionOnly.Tests.dll
25>------ Build started: Project: System.Xml.RW.XmlWriter.Tests, Configuration: Debug Any CPU ------
25>System.Xml.RW.XmlWriter.Tests -> C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.RW.XmlWriter.Tests\net5.0-Debug\System.Xml.RW.XmlWriter.Tests.dll
26>------ Build started: Project: System.Xml.XPath.XmlDocument.Tests, Configuration: Debug Any CPU ------
24>System.Xml.XmlSerializer.Tests -> C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.XmlSerializer.Tests\net5.0-Debug\System.Xml.XmlSerializer.Tests.dll
27>------ Build started: Project: System.Xml.XPath.Tests, Configuration: Debug Any CPU ------
26>System.Xml.XPath.XmlDocument.Tests -> C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.XPath.XmlDocument.Tests\net5.0-Debug\System.Xml.XPath.XmlDocument.Tests.dll
28>------ Build started: Project: System.Xml.Xsl.XslCompiledTransformApi.Tests, Configuration: Debug Any CPU ------
27>System.Xml.XPath.Tests -> C:\Users\isiah\github\runtime\artifacts\bin\System.Xml.XPath.Tests\net5.0-Debug\System.Xml.XPath.Tests.dll
29>------ Build started: Project: XsltCompiler.Tests, Configuration: Debug Any CPU ------
28>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\ModuleCore\netstandard2.0-Debug\ModuleCore.dll' could not be found
28>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlCoreTest\net5.0-Debug\XmlCoreTest.dll' could not be found
28>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlDiff\netstandard2.0-Debug\XmlDiff.dll' could not be found
28>Done building project "System.Xml.Xsl.XslCompiledTransformApi.Tests.csproj" -- FAILED.
30>------ Build started: Project: System.Xml.Xsl.XslTransformApi.Tests, Configuration: Debug Any CPU ------
29>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\ModuleCore\netstandard2.0-Debug\ModuleCore.dll' could not be found
29>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlCoreTest\net5.0-Debug\XmlCoreTest.dll' could not be found
29>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlDiff\netstandard2.0-Debug\XmlDiff.dll' could not be found
29>Done building project "XsltCompiler.Tests.csproj" -- FAILED.
30>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\ModuleCore\netstandard2.0-Debug\ModuleCore.dll' could not be found
30>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlCoreTest\net5.0-Debug\XmlCoreTest.dll' could not be found
30>CSC : error CS0006: Metadata file 'C:\Users\isiah\github\runtime\artifacts\bin\XmlDiff\netstandard2.0-Debug\XmlDiff.dll' could not be found
30>Done building project "System.Xml.Xsl.XslTransformApi.Tests.csproj" -- FAILED.
========== Build: 15 succeeded, 15 failed, 0 up-to-date, 0 skipped ==========

System Info:

PS C:\Users\isiah\github\runtime\src\libraries\System.Private.Xml> dotnet --info
.NET SDK (reflecting any global.json):
 Version:   5.0.100-rc.1.20452.10
 Commit:    473d1b592e

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.17763
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\5.0.100-rc.1.20452.10\

Host (useful for support):
  Version: 5.0.0-rc.1.20451.14
  Commit:  38017c3935

.NET SDKs installed:
  5.0.100-rc.1.20452.10 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.All 2.1.21 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.21 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 5.0.0-rc.1.20451.17 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.1.21 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.1.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 5.0.0-rc.1.20451.14 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.1.7 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 5.0.0-rc.1.20452.2 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Microsoft Visual Studio Community 2019 Preview
Version 16.8.0 Preview 3.1

[krwq]

@isiahto and per my understanding after you dotnet build the src directory it does build afterwards? @ViktorHofer is this something we can easily fix?

[isiahto]

@krwq yup, dotnet build in \runtime\src\libraries\System.Private.Xml\src\ works fine afterwards. It seems like a problem on VS side, since restore nor build works in there?

[ViktorHofer]

@isiahto I pinged the NuGet team to re-discuss how we can fix this long standing issue. In the meantime these steps should work:

1. Clone project
2. Build project at root with: build -subset clr+libs -runtimeConfiguration Release
3. Build the solution with the dotnet SDK dotnet build src\libraries\System.Private.Xml
4. Disable NuGet restore inside VS.
5. Open the solution with the latest VS Preview version.

[ViktorHofer]

Note that you also need https://github.com/dotnet/runtime/pull/42678 to fix an illink issue during the build.