Runtime: Improve code coverage for System.Data.Common (53.2%)

[danmosemsft]

https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows/Code_Coverage_Report/

[the-dwyer]

@danmosemsft I am working on some unit test for this code and I will submit a pull request. Thanks, Michael

[danmosemsft]

Info on code coverage work:

1) Here's the all up report
https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows/Code_Coverage_Report/
Caveat - doesn't show coverage of any types whose implementation is in corelib (eg String, etc). If you want to look at that for now you must gather manually using instructions below.

2) Docs on code coverage work are here
https://github.com/dotnet/corefx/blob/master/Documentation/building/code-coverage.md
and some in
https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/developer-guide.md

3) There's innumerable places to add coverage -- we would love to focus on the most heavily used types and the least covered types to get the most benefit.

[danmosemsft]

@the-dwyer did you end up making progress? :)

[ThatsCloseEnough]

@danmosemsft I'd be willing to write some unit tests, however what is the convention on testing internal classes?
For example i would like to test BigIntegerStorage which is a internal class. Normally i would add internalsvisible to the other project, is this allowed?

[danmosemsft]

@ThatsCloseEnough we try to avoid it. Generally our public API is a reasonable unit testing surface. There are a few instances of it. Can you test via the public API?

[karelz]

No progress in a while ... unassigning

[LTMenezes]

I’d like to tackle this if there’s no one working in this right now.

[danmosemsft]

Yes please go for it @LTMenezes

[LTMenezes]

Great, I will start working on it. I will probably ask for feedback from you guys on the upcoming week as this is my first issue here.

[karelz]

Great! @LTMenezes I sent you collaborator invite - see reason, fallout and details here.

[LTMenezes]

@karelz I just accepted the invite, looking forward to contributing.

[LTMenezes]

I'm planning on opening a small PR with unit tests for the class System.Data.Common.DataTableMapping to get feedback from you guys and see if I'm going in the right direction. What do you guys think? Should I proceed with this PR?

[danmosemsft]

That sounds great! A small PR first would help check you're in the right direction.

[LTMenezes]

@danmosemsft Should I assign some reviewer in the PR?

[danmosemsft]

The code owners are in https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/issue-guide.md
In this case one of @keeratsingh, @afsanehr, @david-engel would probably review it.

[ajcvickers]

Closing as we don't intend to make any changes here.