Runtime: Add a runtime configuration to disable diagnostics server
Currently the diagnostics server is always created and there is no way of configuring the runtime to not do this. We should add an optional config switch that allows users to disable creation of the diagnostics server thread entirely.
cc @noahfalk @josalem
sywhang
All 6 comments
I'd recommend reusing the switch we already have: COMPLUS_EnableDiagnostics
@hoyosjs - this could also be used as a workaround to the performance issue you mentioned. I wasn't able to find it or I would I have linked it.
noahfalk
on 11 Oct 2019
I think we should do this for 3.1. The implementation should be super-cheap and it is a good risk mitigation against future diagnostics server bugs we may discover.
noahfalk
on 11 Oct 2019
dotnet/runtime#13275 was the issue @duskembayev was seeing. After shutdown the pipe seems to linger doing ACL queries under a sandboxed scenario. This is exactly the fix he had tried but it was just never hooked to the check. dotnet/coreclr#27137 fixes it, is there any way you can give this a try? Does this unblock you?
hoyosjs
on 11 Oct 2019
Reopening for 3.1 port
sywhang
on 11 Oct 2019
Fix has been merged to master. 3.1 port is here: dotnet/coreclr#27140
sywhang
on 11 Oct 2019
Closing as 3.1 port has been merged.
sywhang
on 15 Oct 2019
Related issues
iCodeWebApps
路
3Comments
Timovzl
路
3Comments
EgorBo
路
3Comments
btecu
路
3Comments
chunseoklee
路
3Comments
Most helpful comment
I think we should do this for 3.1. The implementation should be super-cheap and it is a good risk mitigation against future diagnostics server bugs we may discover.