Runtime: Remove `clean.sh` and `clean.cmd`

[Gnbrkm41]

I'm trying to clean the working directory while working on stuffs. I was able to do cleanups by passing -clean argument to the build script when I was working on corefx; it appears that for coreclr, such argument isn't present and I have to use the clean.cmd or clean.sh.

However, when I try to execute the script, MSBuild seem to output some error that seems to depend on some files present in a specific folder. Here's the output from build.cmd:

C:\Users\gotos\source\repos\coreclr>clean
Installing dotnet using Arcade...
running: powershell -NoProfile -ExecutionPolicy unrestricted -Command ". C:\Users\gotos\source\repos\coreclr\eng\configure-toolset.ps1; . C:\Users\gotos\source\repos\coreclr\eng\common\tools.ps1; InitializeBuildTool"

Name                           Value
----                           -----
Path                           C:\Users\gotos\source\repos\coreclr\.dotnet\dotnet.exe
Command                        msbuild
Tool                           dotnet
Framework                      netcoreapp2.1


Running: dotnet msbuild /nologo /verbosity:minimal /clp:Summary /nodeReuse:false /flp:v=normal;LogFile=clean.log /t:CleanAllProjects
C:\Users\gotos\source\repos\coreclr\all.locproj(14,3): error MSB4019: 가져온 "C:\tools\devdiv\loc\Loctask\Localization.settings.targets" 프로젝트를 찾을 수 없습니다. <Import> 선언에 지정한 경로가 올바른지 그리고 파일이 디스크에 있는지 확인 하세요.

빌드하지 못했습니다.

C:\Users\gotos\source\repos\coreclr\all.locproj(14,3): error MSB4019: 가져온 "C:\tools\devdiv\loc\Loctask\Localization.settings.targets" 프로젝트를 찾을 수 없습니다. <Import> 선언에 지정한 경로가 올바른지 그리고 파일이 디스크에 있는지 확인 하세요.
    경고 0개
    오류 1개

경과 시간: 00:00:00.10

(yes, it's in Korean... but it's the same as the one from build.sh, which is in English)
and here's the one from build.sh, ran on WSL2 Ubuntu:

ganbarukamo@DESKTOP-DH26CRU:~/source/repos/coreclr$ ./clean.sh
Running init-dotnet.sh
Installing dotnet using Arcade...
Running: /home/ganbarukamo/source/repos/coreclr/.dotnet/dotnet msbuild /nologo /verbosity:minimal /clp:Summary /flp:v=normal;LogFile=clean.log /t:CleanAllProjects
/home/ganbarukamo/source/repos/coreclr/all.locproj(14,3): error MSB4019: The imported project "/tools/devdiv/loc/Loctask/Localization.settings.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.

Build FAILED.

/home/ganbarukamo/source/repos/coreclr/all.locproj(14,3): error MSB4019: The imported project "/tools/devdiv/loc/Loctask/Localization.settings.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.
    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:00.09
ERROR: An error occurred in /home/ganbarukamo/source/repos/coreclr/.dotnet/dotnet msbuild /nologo /verbosity:minimal /clp:Summary /flp:v=normal;LogFile=clean.log /t:CleanAllProjects. Check logs under /home/ganbarukamo/source/repos/coreclr.

What is that C:\tools\devdiv\loc\Loctask\Localization.settings.targets project about? is the script an internal tool only and not supposed to run outside?

[Gnbrkm41]

Wrong label 😒

[jashook]

clean.sh and clean.cmd are deprecated and ready to be removed. The current guidance is to use git clean ... to cleanup the repository artifacts. /cc @dotnet/coreclr-infra

[AaronRobinsonMSFT]

@Gnbrkm41 The safest workflow for cleaning is as follows:

Use the following to verify what git will remove:
git clean -xdn

To actually clean the repository use the following:
git clean -xdf

[BruceForstall]

@jashook @AaronRobinsonMSFT One thing clean.cmd/sh can/could do is clean out the NuGet caches that don't live in the source clone. Is there a recommended alternative scripting for doing that?

[jashook]

It is unclear if we want to do that. It is possible there is another project that uses the global nuget cache and nuking it from some script in the coreclr repo silently could cause problems elsewhere.

[AaronRobinsonMSFT]

It is possible there is another project that uses the global nuget cache and nuking it from some script in the coreclr repo silently could cause problems elsewhere.

Agreed.

Another aspect of this is that to my knowledge there isn't a surgical way to remove specific NuGet packages but leave others. In order to do the targeted removal we would probably need to write some script that searches and then deletes only those we want to remove, which seems like an onerous task and has the added complexity referred to by @jashook.

[BruceForstall]

This script is / would be only run manually, not automatically.

And the nuget cache is a cache, right, so anything there can always be restored?

I have only ever used it when it ask myself "hey, why do I have so little disk space after I've cleaned everything on this machine? Oh, nuget is eating XXXX MB of space..."

[jashook]

The comment still stands as it would silently modify global machine state. In my opinion this should be done very explicitly by the user.

[sbomer]

@BruceForstall AFAIK the recommended way to do that is

dotnet nuget locals --clear global-packages

[BruceForstall]

If that works (I'll have to try...), that makes sense.

[Gnbrkm41]

So then looks like the scripts are not in use anymore & there are alternatives to achieve the same. I'll leave this issue to track the deletion of the build.sh/build.cmdclean.sh/clean.cmd files then.

[trylek]

Just for clarity - I think this is actually about deleting the scripts clean.sh / clean.cmd, not build.sh / build.cmd - the build scripts are still used and, while there are discussions about partially or completely switching them over to use an msbuild script instead, this hasn't been done yet and in fact there's not even a complete agreement on the team yet how that should be done.

[Gnbrkm41]

Oops. I meant clean.cmd and clean.sh...

[trylek]

Thank you!

[jkotas]

clean.cmd/sh scripts do not exist in dotnet/runtime repo anymore.