Runc: Need to add integration test suite for resource limitation (especially for devices)

[AkihiroSuda]

https://github.com/opencontainers/runc/blob/master/tests/integration/cgroups.bats

The current test suite doesn't cover resource limitation stuff except memory.kernel.

[AkihiroSuda]

We could extend the current bats suite to cover them, but we should also consider port over https://github.com/containers/crun/tree/master/tests (Python) for ease of json manipulation.
(The current crun suite seems to cover PID limits, but doesn't seem to cover cpu and memory anyway.)

cc @giuseppe

[ahmedaabouzied]

I can work on that

[AkihiroSuda]

Thanks, please feel free to open PR

[kolyshkin]

The current test suite doesn't cover resource limitation stuff except memory.kernel.

There's also https://github.com/opencontainers/runc/blob/master/tests/integration/update.bats which tests many other controllers.

@AkihiroSuda what kind of tests do you have in mind?

[AkihiroSuda]

I think we need to add tests for devices (if we don't have yet)

[ahmedaabouzied]

I think we need to add tests for devices (if we don't have yet)

@AkihiroSuda, could you explain more or maybe provide an example of tests for devices?

[AkihiroSuda]

Like this but as integration tests
https://github.com/opencontainers/runc/blob/master/libcontainer/cgroups/ebpf/devicefilter/devicefilter_test.go

[AkihiroSuda]

@ahmedaabouzied Are you still working on this?

[ahmedaabouzied]

Actually, I couldn't get any far with this.

[EduardoVega]

@AkihiroSuda I would like to work on this one if it is still required.

[AkihiroSuda]

Yes please, thanks