Rules_nodejs: Update documentation style

Created on 11 Aug 2020  路  8Comments  路  Source: bazelbuild/rules_nodejs

馃殌 feature request

Relevant Rules

Description

The documentation is incredibly difficult to parse and seem quite different from every other set of rules

rules_swift
rules_cc
rules_rust

Describe the solution you'd like

The documentation should be restructured such that each rule has a table that describes all of it's attributes

Screen Shot 2020-08-11 at 12 46 54 PM
Screen Shot 2020-08-11 at 12 47 06 PM

Describe alternatives you've considered

I'm not sure what the workaround should be. My reference to rules_cc is just a suggestion. There's likely a bunch of ways to improve readability but I do feel it's a problem with these rules.

questiodocs

Most helpful comment

To keep this issue updated, first pass of the refreshed docs are here, working on the final tweaks and fixes currently.
https://mattem.github.io/rules_nodejs/

All 8 comments

Thanks for the issue, we spoke about a design refresh in our teams meeting today, so this is good timing.
I think this is something we can look into doing, there are a few other bits that need fixing with the doc generation too while we are in there.

@mattem Hey, thanks for the quick reply 馃槂

Is there an issue tracking those things you mentioned you want to do?

I don't think there are separate issues for each item on the list, but this is what springs to mind:

  • Docs search isn't working #1282
  • Since switching to stable as the default branch, it's a manual step in the release to push to master for the doc site
  • There are references to the internal //packages labels still in some documented rules and examples, we should apply the same substitutions to the docsgen as to the published packages
  • In order to flip --incompatible_no_rule_outputs_param, we need to address some doc generation issues around macros #1303

Also, it kinda irks me that there isn't a consistent style for the canonical rule sets in the bazelbuild org, but that's outside the scope here I think.

I should mention that I started working on making the docs look more like the main bazel.build docs, which seems a good fit for the larger docs that rules_nodejs has

@mattem Awesome! All those things sound super exciting! Thanks so much for sharing, I really appreciate it 馃槂

To keep this issue updated, first pass of the refreshed docs are here, working on the final tweaks and fixes currently.
https://mattem.github.io/rules_nodejs/

It's gorgeous!! 馃ぉ

2122 now merged, and live at https://bazelbuild.github.io/rules_nodejs/

I think I'll close this, and we can now open more focused issues for follow up items

It looks way better! Thank you so much!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rzhw picture rzhw  路  5Comments

Toxicable picture Toxicable  路  6Comments

uri-canva picture uri-canva  路  7Comments

solomatov picture solomatov  路  7Comments

Globegitter picture Globegitter  路  5Comments