Rubocop: $? and $CHILD_STATUS are not equivalent

[maasha]

Rubocop says:

rubocop test.rb
Inspecting 1 file
C

Offenses:

test.rb:5:13: C: Prefer $CHILD_STATUS from the English library over $?.
fail unless $?.success?
            ^^

1 file inspected, 1 offense detected

However, $? is set for system call and $CHILD_STATUS is not:

./test.rb:6:in `<main>': undefined method `success?' for nil:NilClass (NoMethodError)

Code below:

#!/usr/bin/env ruby

system('pwd')

fail unless $?.success?
fail unless $CHILD_STATUS.success?

[mattjmcnaughton]

I think you need to require the "English" library. ruby-doc says the two should be interchangeable, if the library is required.

So for your test code to work it should be:

#!/usr/bin/env ruby

require 'English'

system('pwd')

fail unless $?.success?
fail unless $CHILD_STATUS.success?

[bbatsov]

It's even in the message:

test.rb:5:13: C: Prefer $CHILD_STATUS from the English library over $?.

[arturopie]

I got the same error after using Rubocop auto-correct. Shouldn't the auto-correct add require "English"?

[bbatsov]

Normally you'd require it just once in your entire project, that's why auto-correct doesn't insert it. It's an easily fixable breakage, so I think most people would be fine with it.

[matkoniecz]

Is there somewhere list of auto-correct rules that may break things, like this one?

[jonas054]

@matkoniecz As far as I know, there is no such list.

[jaredbeck]

Instead of:

test.rb:5:13: C: Prefer $CHILD_STATUS from the English library over $?.

it might be more clear as:

test.rb:5:13: C: Prefer $CHILD_STATUS (must `require 'English'`) over $?.

[jonas054]

I'm re-opening the issue while we consider if we should change the message as per @jaredbeck's suggestion.

Even though it might be argued that requiring English in the offending file is unnecessary more often than not, I still think this message is an improvement and avoids some confusion, so my vote is yes.

[ivanovaleksey]

By the way the message on current master branch is

C: Prefer $CHILD_STATUS from the stdlib 'English' module over $?.