Rubocop: Policy on "disable because I disagree" issues?

Created on 22 Jun 2018  Â·  1Comment  Â·  Source: rubocop-hq/rubocop

Now and then we get an issue that, in essence, argues that some cop should be disabled by default because the author disagrees with it. These issues tend to be entirely based on Strong Opinionâ„¢, and aren't really helpful to the development of RuboCop.

Perhaps we should have something about this in the documentation, that can also be pointed to for quick closure of issues. WDYT @bbatsov?

There are some tangential issues. For example unsafe auto-corrects should rightly be disabled, and perhaps some cops with a high propensity for false positives. This shouldn't affect those.

question

Most helpful comment

Just close such issues.

There are some tangential issues. For example unsafe auto-corrects should rightly be disabled, and perhaps some cops with a high propensity for false positives. This shouldn't affect those.

Agreed. Those are going to be finally solved for good by the new Safety levels. We even have a PR in progress on this.

>All comments

Just close such issues.

There are some tangential issues. For example unsafe auto-corrects should rightly be disabled, and perhaps some cops with a high propensity for false positives. This shouldn't affect those.

Agreed. Those are going to be finally solved for good by the new Safety levels. We even have a PR in progress on this.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ecbrodie picture ecbrodie  Â·  3Comments

NobodysNightmare picture NobodysNightmare  Â·  3Comments

david942j picture david942j  Â·  3Comments

printercu picture printercu  Â·  3Comments

mikegee picture mikegee  Â·  3Comments