Rtl_433: acurite5n1 rain accumulation issue with multiple sensors

Created on 13 Jan 2017  路  3Comments  路  Source: merbanan/rtl_433

rain accumulation logic breaks when more than one sensor reporting, as they are not tracked separately. Current code might mistake this for rain counter wrap-around.

example here:
https://gist.githubusercontent.com/zerog2k/6340a71252015d1032314b7e99d0b6e9/raw/e4bde902d8813a66d6b9935bc579be739d3b0742/gistfile1.txt

Most helpful comment

My vote is to just report the raw value (0.01 or whatever to get the units right). Then clients can do what ever they want. In general I think rtl_433, should hand the RF bits, parse/validate athe framing to know when valid messages are received and then get out of the way.

If you are going to keep state and report deltas, then it should be as accurate and handle the edge cases such as multiple stations being in range, wraparounds, sensor reset, etc.

All 3 comments

My vote is to just report the raw value (0.01 or whatever to get the units right). Then clients can do what ever they want. In general I think rtl_433, should hand the RF bits, parse/validate athe framing to know when valid messages are received and then get out of the way.

If you are going to keep state and report deltas, then it should be as accurate and handle the edge cases such as multiple stations being in range, wraparounds, sensor reset, etc.

Please remove the state tracking in this case. I agree with @rct.

Addressed in #893 now. Pending on discussion in #827.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ALEEF02 picture ALEEF02  路  9Comments

majkrzak picture majkrzak  路  3Comments

BenWoodford picture BenWoodford  路  5Comments

Tehrasha picture Tehrasha  路  8Comments

Piruzzolo picture Piruzzolo  路  11Comments