Rspec-rails: Work out testing story for ActionCable

Created on 24 Apr 2016  Â·  11Comments  Â·  Source: rspec/rspec-rails

We currently don't have one, so we should definitely work out what the story is.

rails5

Most helpful comment

Hi, @samphippen!

I've extracted rails/rails#23211 into a gem and added RSpec support too – https://github.com/palkan/action-cable-testing.

All 11 comments

I made this ruby client for action cable: https://github.com/NullVoxPopuli/action_cable_client
could it help with testing action cable?

Hi @NullVoxPopuli, thanks for the suggestion, but we're going to take RSpec in a slightly different direction to test with ActionCable 😄

Whats the official Rails line on this @samphippen ?

Waiting for https://github.com/rails/rails/pull/23211 to be merged before I start investigating.

Hi, @samphippen!

I've extracted rails/rails#23211 into a gem and added RSpec support too – https://github.com/palkan/action-cable-testing.

@samphippen @benoittgt

Hey, folks! It's been a while...

Since action-cable-testing has been merged into Rails 6.0, we think it's time to take care of RSpec part)

The gem already has RSpec support (built using the same structure as rspec-rails), so it's gonna be pretty easy to merge it.

The main question for now is whether we should use the RSpec 4.x branch or target the 3.x version?

TBH if you target 3.x it's going to be easy to cherry-pick it to 4.x, but it really depends on if we want to release this before 4.x, which is scheduled for release around rails-conf

the 3.xx series will likely not get rails 6.0 support, so you should target 4.xx

Ah if this is intended as an Rails 6.0 only feature then yes definitely just 4.x

if this is intended as an Rails 6.0 only feature

Yep, it's Rails 6+.

Ok, thanks guys; we'll provide a PR for 4.x.x.

We merged support for this, closing.

Was this page helpful?
0 / 5 - 0 ratings