Rspamd: PID file no longer gets created

[windware-ono]

Classification (Please choose one option):

• [ ] Crash/Hang/Data loss
• [ ] WebUI/Usability
• [ ] Serious bug
• [x] Other bug
• [ ] Feature
• [ ] Enhancement

Reproducibility (Please choose one option):

• [X] Always
• [ ] Sometimes
• [ ] Rarely
• [ ] Unable
• [ ] I didn’t try
• [ ] Not applicable

Rspamd version:

1.7.3 (1.7.3-1~xenial)

Operation system, CPU, memory and environment:

Ubuntu 16.04 64bit

Description (Please provide a descriptive summary of the issue):

It no longer creates the PID file with the log saying,

main: skip writing pid in no-fork mode

even when specified in 'rspamd.conf' under 'options' -> 'pidfile'.

Compile errors (if any):

Steps to reproduce:

Start rspamd.

Expected results:

PID file should still be created when not forking.

Actual results:

PID file no longer gets created.

Debugging information (see details here):

Configuration:

Additional information:

It became a problem as I could no longer monitor rspamd by checking on its PID file.

To get the PID file, systemd launch script has to be changed by taking '-f' option out of 'ExecStart' and add 'Type=forking'.

[fatalbanana]

That was done to try simplify packaging AFAIU (on suggestion of people making efforts to package rspamd for Fedora). It's confusing that pidfile should not be honoured indeed.

You could get the PID from systemd:
~~~

export systemctl -p MainPID show rspamd.service

do something with $MainPID

~~~

[mgollo]

I have just discovered that in our production instance (on Debian stable) we cannot monitor the rspamd process anymore since this requires a PID file. I think at least if there is a pid file path configured, a PID file should be written. There are still tools that use it and backwards compatibility is not a bad thing. You can just disable writing a PID file in the config of a Fedora package, no need to remove the functionality.

[windware-ono]

I still would like to have PID file support as every time I update the rspamd package, it reverts the changes I made in systemd config file and the monitoring complains that the service cannot be found as no longer a PID file is written.

I do have options such as monitoring by process name or with the above 'export' command, write down the PID to a file in an interval but having an official PID file is the cleanest solution.

[caffeinejolt]

Agreed - having a PID file for systems like monit would be very useful.

[julian70400]

Same problem here on Debian 10 buster, no way to monitor Rspamd with Monit..

[vstakhov]

Is it anyhow related to Rspamd? Are you using the packages that I provide?

[julian70400]

I currently use : http://rspamd.com/apt-stable/ buster main
rspamd works like a charm except it do not generate pid file (which, as I said, making troubles for monitoring).
If you have any ideas, I am interested.

[DamonFstr]

+1 on having a PID file for systems like monit

Edit: Potential workaround that I found - https://serverfault.com/questions/270316/monit-check-process-without-pidfile/285596#285596. I haven't tested this yet

[julian70400]

Another way to work with monit without PID is a config like this :

check process rspamd
    matching 'rspamd: main process'
    start program = "/sbin/service rspamd start"
    stop program = "/sbin/service rspamd stop"

   if cpu is greater than 40% for 2 cycles then alert
   if cpu > 60% for 5 cycles then alert
   if memory > 80% for 4 cycles then alert
   if totalmem > 512 MB for 5 cycles then alert

Works like a charm !

[windware-ono]

What is the status of this issue?
While the above comment's method works, finding a process by its name isn't the cleanest solution and I still would like to have a PID file generated.