Rpcs3: Possible usage of null pointer in np_handler.cpp

Created on 12 May 2020  路  3Comments  路  Source: RPCS3/rpcs3

cur_ip = p; should be used inside else statement because it delete previous value of cur_ip and may be nullptr when .c_str() will be executed

https://github.com/RPCS3/rpcs3/blob/5692c3de0482659e723e821338febd8c9b5d1255/rpcs3/Emu/NP/np_handler.cpp#L66-L75

Most helpful comment

@elad335 , since we are not professionals, we need an approval from the genius, maybe optimization is restricted for some reason. Please don't be angry at us. We are just trying to be helpful.

All 3 comments

I dont understand why creating these issues over small code changes which are obviously correct. regardless feel free to open a pull request to fix this.

@elad335 , since we are not professionals, we need an approval from the genius, maybe optimization is restricted for some reason. Please don't be angry at us. We are just trying to be helpful.

Even if the fix was wrong or not you should always be encouraged to make a PR anyways hahah. That鈥檚 the whole reason why pull requests are a thing :p

Was this page helpful?
0 / 5 - 0 ratings

Related issues

JohnGodgames picture JohnGodgames  路  3Comments

AniLeo picture AniLeo  路  3Comments

Birch-san picture Birch-san  路  3Comments

kurosh10000 picture kurosh10000  路  3Comments

altiereslima picture altiereslima  路  3Comments