Rpcs3: The Legend of Heroes: ToCS2 - Clamping issues on vertex shader

[alex88510]

I believe this issue has been there since the very early stage and not a regression from any recent PR.
I also believe the same issue also occurs on ToCS1.

In some scenes, some of the objects (e.g. rooftops, the top of a train, top of a crate box) having abnormally high brightness.
Below is an example of those, where some carpets in the room are very bright (as if the sun was shining at it).

Since it doesn't really affect the gameplay and only cause very minor graphic issue, I didn't bother to raise it previously.

EDIT: Let me know what is needed for debugging. Logs? renderdoc?

[PeterTh]

Interestingly enough, I think that's a bug I encountered and solved when porting the game to PC. IIRC, some shaders don't limit an intermediate value to the 0..1 range even though that was the intended behaviour (and apparently the hardware on PS3 did it).

Edit: just looked it up in the git log, and yeah, it was an output value of the vertex shader not being clamped to [0,1].

[kd-11]

Yea, its a common problem with PS3. The real hardware is also very inconsistent on when it does apply clamping of inputs making this a complicated issue that needs testing via a bot. I have some work on this done but I've yet to have time to set up all required instructions / setups.

[alex88510]

Seems like it is an issue way more complicated than I expected.
Do you still need any logs/renderdoc for debugging?

[kd-11]

Rsx capture would help.

[masaki1988]

Same issue i think here https://github.com/RPCS3/rpcs3/issues/6088 but maybe im wrong.

[alex88510]

@kd-11 here you go https://mega.nz/#!DVxXza7B!Y_hGBiNmfDP5I6VhROToA5I4RSoCMqLHhXvB-Js_TJM

[alex88510]

It seems it was fixed either by the latest PR(#6388 ) or some other PR that got merged after this issue was raised (didn't keep track of it)

If need me find out which exact PR that solve this, let me know.
I haven't done much testing on it, will do more testing later. Otherwise, this can be closed?

[AniLeo]

If it's fixed on master, you can close

[alex88510]

Ok, tested on latest master, it is not fixed...lol

Likely to be kd-11's MGS4 PR that fixes it.
I guess I will close this once that PR is merged.

[kd-11]

Yea the mgs4 PR implements autoclamping in som registers just as hypothesized. Took days of hardware tests to get them all but it seems to help a lot of games.

[greentop]

@kd-11 It's fixed from PR#6388

Master:

PR#6388:

[alex88510]

Closing this as PR#6388 has been merged and fixed the issue.