Rpcs3: Game crash when GPU Texture Scaling is not enabled

[uaqlover]

last build the game was working RPCS3 v0.0.4-6095-222c0e0f Alpha | HEAD

in this build it break the game
RPCS3 v0.0.4-6107-380f90b0 Alpha | HEAD

the log file

RPCS3 v0.0.4-6095

RPCS3 v0.0.4-6095.log.gz

RPCS3 v0.0.4-6107

RPCS3 v0.0.4-6107.log.gz

[AniLeo]

380f90b0 is #3727
Which doesn't touch rsx_cache

And for the issue to be the PR's ERROR_INVALID_PARAMETER, before that PR the game would have to throw a Win32 error

This one can probably be fixed without knowing in which build it got broken though

[Emulator-Team-2]

@AniLeo
The title is wrong this error has been fixed a long time ago.
On latest master build this games crashes with (Unhandled Win32 exception).

[AniLeo]

Can you upload a log for master?

[Emulator-Team-2]

Fixed by #5785
Note:
-This game require to enabled Use GPU texture scaling in debug settings.
-'GPU texture scaling' was moved to debug setting some time ago because it caused issues in some games.
-Crash Commando has always required this option.

[AniLeo]

@kd-11 can you check why this game requires that? weird

[Emulator-Team-2]

Note: [ VK and GL texture cache error after enabling GPU texture scaling is fixed by #5785. ]

Logs from Latest Master build.

Without GPU texture scaling:

Win32-error-screenshot

RPCS3.zip

With GPU texture scaling crashes with:
[Vulkan]
E {RSX [0x0200504]} RSX: Blit request denied because the source region does not fit! F {RSX [0x0200564]} RSX: class std::runtime_error thrown: Assertion failed: !region.is_locked() (in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\vktexturecache.h:967)
[OpenGL]
F {RSX [0x0200564]} RSX: class std::runtime_error thrown: Assertion failed: !cached.is_locked() (in file c:\projects\rpcs3\rpcs3\emu\rsx\gl\gltexturecache.h:858)
RPCS3-GPU texture scaling.zip

[uaqlover]

with https://github.com/RPCS3/rpcs3/pull/5785/commits/3867400a734deed171acf7bc21f9bded2da26439 still game crashes with (Unhandled Win32 exception). but when enabling GPU texture scaling it works fine

[kd-11]

Retest please.

[Emulator-Team-2]

Tested with the latest master build (0.0.6-8330) no change.
Still crashes with error (Unhandled Win32 exception) without enabled GPU texture scaling.

[kd-11]

Fixed by https://github.com/RPCS3/rpcs3/pull/6164