Rpcs3: [DX12 ] HRESULT = The parameter is incorrect

[SakataGintokiYT]

@kd-11
@raven02

Tested on build : [af79affa]
[DX12]
Game list :
-Castle Crashers
-Dragon Ball: Raging Blast
-Dragon Ball: Raging Blast 2
-J-Stars Victory VS+
-Dark Mist
-Dragon Ball: Xenoverse
-Majin and the Forsaken Kingdom
-Mad Riders
-Battle Fantasia
-UFC 2009 Undisputed
-Meikyuu Touro Legasista JPN

• Probably more

{rsx::thread} class fmt::exception thrown: D3D12GSRender::flip(): The parameter is incorrect.
(in file C:rpcs3rpcs3EmuRSXD3D12D3D12GSRender.cpp:522)

[tambry]

It's simply and indication that driver is unable to render that frame, because something was done wrong. This is rather a symptom than the actual problem. It should probably reported separately for every game with the proper debug output enabled.

[tambry]

Well, debug output expects you to actually be running in Visual Studio. It reports to the Visual Studio debug output.

[SakataGintokiYT]

@kd-11

Do you know how to fix it ?

[kd-11]

@SakataGintokiYT the fix is actually there in the code, but disabled (and set to always fail because of this). I don't know why vlj disabled the fallback path, but trying to create a resource with dimensions of zero causes this error since the initialization block is never run. If you want to test, change the if (false) clause on line 494 in D3D12GSRender to if (true) and it should work. If it works consistently enough, we can enable it by default and add a message instead of proceeding to the buggy section.

[SakataGintokiYT]

@kd-11 It works ^___^

[kd-11]

That path is taken when a flip is issued without a surface target being set. on vulkan and gl, we simply ignore blitting anything to screen and clear to black. I could set up a workaround that does the same for DX12

[SakataGintokiYT]

@kd-11
Looking forward to your update. :)

[kd-11]

Fix added with https://github.com/RPCS3/rpcs3/pull/1766