Routing-controllers: Please support OAuth providers with @Authorized

Created on 28 Jul 2019 · 5Comments · Source: typestack/routing-controllers

It would be nice to if we can get some nicer out of the box support or some examples of how to support OAuth providers.

OAuth providers are covered in passport.js who currently support 500+ providers known as strategies. But this would require us using @UseBefore(passport.authenticate(string)) and not the @Authorized() middleware.

The question:
What are your recommendations for using @Authorized() with third party OAuth providers like Facebook / Google?

awaiting answer

Source

gruckion

Most helpful comment

@gruckion, it can be implemented with next configuration:

import express from 'express';
import { Action, useExpressServer } from 'routing-controllers';

const app = express();

useExpressServer(app, {
  authorizationChecker: (action: Action) => new Promise<boolean>((resolve, reject) => {
    passport.authenticate('bearer', (err, user) => {
      if (err) {
        return reject(err);
      }
      if (!user) {
        return resolve(false);
      }
      action.request.user = user;
      return resolve(true);
    })(action.request, action.response, action.next);
  }),
  currentUserChecker: (action: Action) => action.request.user,
});

Then you'll be able to use both @Authorized() and @CurrentUser decorators.

However @UseBefore(passport.authenticate(string)) is not so bad as well.

DimaIT on 4 Sep 2019

❤3

All 5 comments

Any updates?

gruckion on 24 Aug 2019

@gruckion, it can be implemented with next configuration:

import express from 'express';
import { Action, useExpressServer } from 'routing-controllers';

const app = express();

useExpressServer(app, {
  authorizationChecker: (action: Action) => new Promise<boolean>((resolve, reject) => {
    passport.authenticate('bearer', (err, user) => {
      if (err) {
        return reject(err);
      }
      if (!user) {
        return resolve(false);
      }
      action.request.user = user;
      return resolve(true);
    })(action.request, action.response, action.next);
  }),
  currentUserChecker: (action: Action) => action.request.user,
});

Then you'll be able to use both @Authorized() and @CurrentUser decorators.

However @UseBefore(passport.authenticate(string)) is not so bad as well.

DimaIT on 4 Sep 2019

❤3

@gruckion, it can be implemented with next configuration:

import express from 'express';
import { Action, useExpressServer } from 'routing-controllers';

const app = express();

useExpressServer(app, {
  authorizationChecker: (action: Action) => new Promise<boolean>((resolve, reject) => {
    passport.authenticate('bearer', (err, user) => {
      if (err) {
        return reject(err);
      }
      if (!user) {
        return resolve(false);
      }
      action.request.user = user;
      return resolve(true);
    })(action.request, action.response, action.next);
  }),
  currentUserChecker: (action: Action) => action.request.user,
});

Then you'll be able to use both @Authorized() and @CurrentUser decorators.

However @UseBefore(passport.authenticate(string)) is not so bad as well.

Very nice @DimaIT, I will take a look at this soon and let you know what I end up with.

gruckion on 6 Sep 2019

Stale issue message