Router: Wildcard doesn't include query parameters

Created on 24 Apr 2019  路  8Comments  路  Source: reach/router

https://codesandbox.io/embed/o5pj82wzwy

Open https://o5pj82wzwy.codesandbox.io/app/dashboard?foo=bar

Expected: redirect to /dashboard?foo=bar
Actual: redirect to /dashboard

bug
Source
picture Hypnosphi
👍3

All 8 comments

Will happily merge a PR for this.

ryanflorence picture ryanflorence on 25 Sep 2019

Can I pick this up?

VariableVasasMT picture VariableVasasMT on 25 Sep 2019

Go for it!

ryanflorence picture ryanflorence on 26 Sep 2019

@ryanflorence
I must admit that I am not comfortable with this fix, because of the following issues

  1. Cant insure that location would be provided in props always.
  2. The string construction looks shady

but this is what I could come up with, any help would be appreciated.

VariableVasasMT picture VariableVasasMT on 4 Oct 2019

@ryanflorence I think the code I added is good enough, please review #311

VariableVasasMT picture VariableVasasMT on 21 Oct 2019

@ryanflorence could you look at the pull please.

VariableVasasMT picture VariableVasasMT on 4 Nov 2019

@mtliendo @ryanflorence please review/close the pull request

VariableVasasMT picture VariableVasasMT on 27 Nov 2019
😕2 👀1

can we close this?

VariableVasasMT picture VariableVasasMT on 23 Nov 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

artoodeeto picture artoodeeto  路  4Comments
jsonmaur picture jsonmaur  路  4Comments
EJIqpEP picture EJIqpEP  路  4Comments
florian-bd picture florian-bd  路  3Comments
michaelwiktorek picture michaelwiktorek  路  4Comments