Router: Provide index.d.ts files.

Created on 19 Aug 2018  路  6Comments  路  Source: reach/router

Provide index.d.ts files.

duplicate

Most helpful comment

This is my point of view.

Providing index.d.ts has a better development experience on vscode, and many libraries now offer index.d.ts, whether or not it is developed using typescript.

All 6 comments

This isn't something the library should have to worry about. It's not written in Typescript. Types should go in DefinitelyTyped instead.

Although not written in Typescript, you can also add the index.d.ts file. This gives a consistent smart hint on vscode.

Any update?

Types appear to be available here. See also https://github.com/reach/router/issues/11#issuecomment-424277408

This is my point of view.

Providing index.d.ts has a better development experience on vscode, and many libraries now offer index.d.ts, whether or not it is developed using typescript.

Could any of the repo maintainers let me know if a PR for this would be accepted? I have the commit ready to PR here but the contrib document says to not open PR's without announcing it on an issue first for discussions.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

hardfist picture hardfist  路  3Comments

florian-bd picture florian-bd  路  3Comments

danoc picture danoc  路  3Comments

thupi picture thupi  路  4Comments

jsonmaur picture jsonmaur  路  4Comments