Router: Add all the right propTypes

Created on 9 Jun 2018  路  2Comments  路  Source: reach/router

I was messing around w/ using flow or typescript for this project and so I was lazy on propTypes, but it's time to put them all in. PRs welcome, or I'll get to it eventually.

good first issue
Source
picture ryanflorence

Most helpful comment

Just propTypes, no flow or TS

picture ryanflorence on 9 Jun 2018
👍3

All 2 comments

I am thinking about making a PR. Which of the following ways would you prefer:

  1. add flow type to the source files, and also provides .js.flow. This will enable type check when developing and submitting PRs to router
  2. add .js.flow only
zhujinxuan picture zhujinxuan on 9 Jun 2018
👎1

Just propTypes, no flow or TS

ryanflorence picture ryanflorence on 9 Jun 2018
👍3
Was this page helpful?
0 / 5 - 0 ratings

Related issues

michaelwiktorek picture michaelwiktorek  路  4Comments
danoc picture danoc  路  3Comments
EJIqpEP picture EJIqpEP  路  4Comments
ssured picture ssured  路  3Comments
benwiley4000 picture benwiley4000  路  4Comments