Roslyn: Automatic namespace imports break muscle-memory and impedes typing

[gundermanc]

Version Used:
VS 2019 16.3 Preview 4 (Int Preview)

Steps to Reproduce:

1. Set caret inside of a private non-static method
2. Type 'this.'

Expected Behavior:

Completion list is displayed with non-static member items of this class.

Actual Behavior:

Completion auto-completes to 'CallConvThiscall' and adds a using for System.Runtime.CompilerServices.

Auto-importing is nice but IMO needs to be a bit less aggressive. I frequently find myself needing to undo what it did. One obvious case is when the user types a keyword, especially 'this', 'value', etc. These should never be considered for completion/auto-namespace-import or they should be added to the completion list so the keyword is the selected match when the user types a commit character.

[gundermanc]

cc: @AmadeusW, in case you have any input here.

[CyrusNajmabadi]

The situation above is just a plain bug. Typing 'this' should always prefer a match against 'this' as you type due to it being either a case-sensitive-prefix or 'case-sensitive-exact' match. That it ever preferred CallConvThiscall is just busted. Maybe some sort of race condition?

Tagging @ivanbasov .

[ivanbasov]

@genlu is it the unimported types completion?

[gundermanc]

I'm not seeing 'this' in the completion list at all. I think it's selecting CallConvThiscall because it's indeed the closest match in the list. Seems like adding keywords to the completion list might fix the issue.

[CyrusNajmabadi]

Seems like adding keywords to the completion list might fix the issue.

This should be the case. If you're not seeing keywords in the list, then that is the bug. If you can provide a repro that would be great.

[ivanbasov]

@gundermanc could you please share a screenshot?

I could not repro the issue. Here is mine:

I have this selected.

[gundermanc]

Interestingly it's not repro-ing for me anymore. Perhaps there's something I'm missing.

[CyrusNajmabadi]

@gundermanc could you perhaps have been in a static member?

[gundermanc]

It was a constructor IIRC. Granted, it was in a Razzle project, so perhaps there was something off about the design-time build.

[CyrusNajmabadi]

OMG....
OMG.............

Razzle is still in use..............

OMG....

The bad memories you just made me think about again.......