Roslyn: Add formatting option to remove space before a left curly brace

Created on 8 Jul 2019 · 4Comments · Source: dotnet/roslyn

Proposal: A check box in Tools Options and an Editorconfig rule for controlling the space before the opening curly brace when the opening curly brace is not on a newline.

[ ] Insert space before opening curly brace when not on newline

Area-IDE Blocked Feature Request IDE-Formatter

Source

kendrahavens

👍1

All 4 comments

This feels very non-C#y. It would effectively be a style to go against what pretty much 99.99% (probably more) of the community does.

I think this should fall under: https://github.com/dotnet/roslyn/issues/31691

There would be a way for people to write their own custom formatting rules. But this would not be supported as a full option out of the box.

CyrusNajmabadi on 8 Jul 2019

👎1

I do not know about it feeling "non-C#y", but there have been people requesting this feature since at least 2005.
Also, I do not think it would take too much effort since the option already exists for the syntactically similar C/C++.

If setting up those custom formatting rules is simple and takes little time, then I agree that will serve the purpose for the people that want this feature.

asdfchlwnsgy1236 on 9 Jul 2019

If setting up those custom formatting rules is simple and takes little time, then I agree that will serve the purpose for the people that want this feature.

The goal is not to provide options for every potential one-off scenario that someone wants. That's both a maintenance cost and it greatly increases hte complexity of the implementation (rules have to figure out how they all interact with other rules). A more flexible solution is to just make formatting something 3rd parties can extend. Then roslyn isn't in the business of supporting every one-off formatting choice users want to make.

CyrusNajmabadi on 9 Jul 2019

👍1

The agreement in the design meeting was this isn't an item we would directly add support for, but should ensure that the formatting extensibility model supports implementing things like this. https://github.com/dotnet/roslyn/issues/31691 is tracking that extensibility API.