Roslyn: "Wrap every parameter/unwrap and indent all paramaters" is higher than "create/initialize parameter"

Created on 4 Jan 2019  路  3Comments  路  Source: dotnet/roslyn

These new code fixes have been given a higher priority than "create/initialize parameter" which feels wrong because the former is something you probably do once, the latter I do all the time just after I've written a parameter:

image

Can we change the priority of this?

4 - In Review Area-IDE Bug

Most helpful comment

this is not a codefix though. this is a refactoring. So, as long as there is no selection, they should always be below analyzer fixes. And, across refactorings they can be made lower priority.

All 3 comments

Agreed. These may just need to go in the 'low priority' bucket.

It's not as simple as lowering the priority of the for formatting codefix. There's some simple logic to decide whether to show refactoring first or codefix first.

http://source.roslyn.io/#Microsoft.CodeAnalysis.EditorFeatures.Wpf/Suggestions/SuggestedActionsSource.cs,183

this is not a codefix though. this is a refactoring. So, as long as there is no selection, they should always be below analyzer fixes. And, across refactorings they can be made lower priority.

Was this page helpful?
0 / 5 - 0 ratings