Roslyn: Naming for the new suppression scope

[mavasani]

https://github.com/dotnet/roslyn/pull/31092 added a new namespace scope to suppress diagnostics in namespace and all its descendants. The current naming is "NamespaceAndChildren", but we probably want a better name that is easier to understand.

[sharwell]

📝 'children' is not the correct term because the implementation uses a transitive closure. 'descendants' is the transitive closure of 'children'.

[mavasani]

Also tagging @JosefPihrt

[gewarren]

I like namespaceanddescendants or just namespacedescendants. Some other suggestions:

namespaceplus
namespaceandbelow
namespacerecursive

[JosefPihrt]

Besides my original proposal "NamespaceAndDescendants" I have another suggestion: "NamespaceAndContent"

[mavasani]

We have decided to rename the scope to NamespaceAndDescendants. I will send a PR soon.

[XtroTheArctic]

So, it's merged. Does that mean I can use this?
I'm on VS 15.9.4 and this doesn't seem to work.
Any idea why?

[CyrusNajmabadi]

@XtroTheArctic It was merged into a branch that is in the 16.0 line. So you'll need a very recent build of VS2019. Probably VS2019 preview 2 (which hasn't been released yet).

[XtroTheArctic]

That's awesome news! Thank you very much.