Roslyn: Installing NonNullable Reference Types preview fails

[Suchiman]

Version Used:
15.8.4 / 15.9 preview 2
(english VS on german windows 10 Pro 1803)

Steps to Reproduce:

1. Download preview and unzip
2. Run .\install.bat from elevated prompt

Installing Roslyn Insiders Build
Installing Preview Into C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\devenv.exe
Using VS Instance 75b52a36 at "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise"
"C:\Users\Robin\Downloads\NonNull\tools\vsixexpinstaller\VsixExpInstaller.exe" /rootSuffix: /u /vsInstallDir:"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise" "C:\Users\Robin\Downloads\NonNull\vsix\RoslynDeployment.vsix"
  Running as Admin.
  de-DE
  Nothing to uninstall...
Using VS Instance 75b52a36 at "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise"
"C:\Users\Robin\Downloads\NonNull\tools\vsixexpinstaller\VsixExpInstaller.exe" /rootSuffix: /vsInstallDir:"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise" "C:\Users\Robin\Downloads\NonNull\vsix\RoslynDeployment.vsix"
  Running as Admin.
  de-DE
  Installing local extension: 'C:\Users\Robin\Downloads\NonNull\vsix\RoslynDeployment.vsix'

Unhandled Exception: System.Runtime.InteropServices.COMException: Element not found. (Exception from HRESULT: 0x80070490)
   at Microsoft.VisualStudio.Setup.Configuration.ISetupConfiguration2.GetInstanceForCurrentProcess()
   at Microsoft.VisualStudio.ExtensionManager.ExtensionManagerService.get_VsProductVersion()
   at Microsoft.VisualStudio.ExtensionManager.Utilities.GetRunningSKUVersionAndEdition(String& version, String& edition)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionManagerService.get_VersionAndEdition()
   at Microsoft.VisualStudio.ExtensionManager.InstalledExtensionImpl.get_VsVersion()
   at Microsoft.VisualStudio.ExtensionManager.InstalledExtensionImpl.AssetTargetsVsVersion(IDictionary`2 attributes)
   at Microsoft.VisualStudio.ExtensionManager.InstalledExtensionImpl.RemoveInapplicableAssets()
   at Microsoft.VisualStudio.ExtensionManager.InstalledExtensionImpl..ctor(IExtension extension, String installPath, IEngineHost engineHost, Boolean installedPerMachine)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionEngineImpl.ToInstalledExtension(InstallableExtensionImpl extension, Boolean perMachine)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionEngineImpl.<>c__DisplayClass183_0.<PreviewInstalledExtensions>b__4(InstallableExtensionImpl installableExtension)
   at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionEngineImpl.PreviewInstalledExtensions(InstallableExtensionImpl extension, Boolean perMachine, List`1 previewedInstalledExtensions, IInstalledExtensionList modifiedInstalledExtensionsList)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionEngineImpl.FindRecursiveInstallConflicts(InstallableExtensionImpl extension, IInstalledExtensionList modifiedInstalledExtensionsList, List`1 impactedExtensions, Boolean isNested)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionEngineImpl.ExtensionRequiresAdditionalOperationForInstall(InstallableExtensionImpl extension, IInstalledExtensionList modifiedInstalledExtensionsList, Boolean isNestedExtension, InstallFlags flags, Boolean& performExtensionUpdate)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionEngineImpl.InstallInternal(InstallableExtensionImpl extension, InstallFlags installFlags, IDictionary`2 extensionsInstalledSoFar, List`1 extensionsUninstalledSoFar, IInstalledExtensionList modifiedInstalledExtensionsList, AsyncOperation asyncOp, IProgress`1 progress, Version targetedVsVersion)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionEngineImpl.BeginInstall(IInstallableExtension installableExtension, InstallFlags installFlags, AsyncOperation asyncOp, Version targetedVsVersion)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionEngineImpl.Install(IInstallableExtension extension, InstallFlags installFlags, Version targetedVsVersion)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionManagerService.Install(IInstallableExtension extension, Boolean perMachine)
   at VsixExpInstaller.Program.<>c__DisplayClass16_0.<Main>g__Install|7(IInstallableExtension installableExtension, <>c__DisplayClass16_4& , <>c__DisplayClass16_5& )
   at VsixExpInstaller.Program.<>c__DisplayClass16_0.<Main>g__RunProgram|1()
   at VsixExpInstaller.Program.Main(String[] args)
Command failed to execute: "C:\Users\Robin\Downloads\NonNull\tools\vsixexpinstaller\VsixExpInstaller.exe" /rootSuffix: /vsInstallDir:"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise" "C:\Users\Robin\Downloads\NonNull\vsix\RoslynDeployment.vsix"
System.Management.Automation.RuntimeException: Command failed to execute: "C:\Users\Robin\Downloads\NonNull\tools\vsixexpinstaller\VsixExpInstaller.exe" /rootSuffix: /vsInstallDir:"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise" "C:\Users\Robin\Downloads\NonNull\vsix\RoslynDeployment.vsix"
at Exec-CommandCore, C:\Users\Robin\Downloads\NonNull\tools\utils.ps1: Line 39
at Exec-Console, C:\Users\Robin\Downloads\NonNull\tools\utils.ps1: Line 71
at Use-VsixTool, C:\Users\Robin\Downloads\NonNull\tools\utils.ps1: Line 149
at Install-VsixViaTool, C:\Users\Robin\Downloads\NonNull\tools\utils.ps1: Line 112
at <ScriptBlock>, C:\Users\Robin\Downloads\NonNull\tools\install.ps1: Line 50

Expected Behavior:
Installs successfully

Actual Behavior:
Fails with exception

[jcouv]

Tagging @jmarolf

[jmarolf]

tagging @sharwell who encountered this issue. It appears that this is a breaking change made in 15.8.4

[jcouv]

Ouch. We just released our latest nullable preview and users are hitting this.

@jinujoseph Please prioritize this issue.
Let me know if there is anything I can do to help. Thanks

[jinujoseph]

tracking bug on platform team

[f2calv]

FYI - continues to fail in 15.8.5

[jcouv]

FYI, the fix missed the window for 15.8.5, but is scheduled as part of 15.8.6. Sorry for the wait.

[jcouv]

15.8.6 was just released. I may not be able to confirm the fix this afternoon. If anyone here does try, please share your result. Thanks!

[Suchiman]

@jcouv yay! it works!

[jcouv]

Awesome. Thanks @Suchiman for confirming.

[Craigfis]

It won't install on 15.9.0 preview 3 for me.

[jcouv]

@Craigfis The nullable preview installer only installs on an RTM version of VS. 15.8.6 is recommended at the moment (latest RTM bits).

[pellea]

@jcouv Is it possible - at our own risk - to install it on the latest preview bits?

[jcouv]

Please update to 15.8.6. The issue with 15.8.5 was fixed there.
Otherwise, you can checkout roslyn, 'restore.cmd', 'msbuild /v:m /m roslyn.sln' and 'devenv /rootSuffix RoslynDev'

---

From: Adrien Pellegrini [e-mail]
Sent: Tuesday, October 23, 2018 2:35:44 AM
To: dotnet/roslyn
Cc: Julien Couvreur; Mention
Subject: Re: [dotnet/roslyn] Installing NonNullable Reference Types preview fails (#29987)

@jcouvhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjcouv&data=02%7C01%7Cjcouv%40microsoft.com%7C60fec87481f343c5707008d6384d2ded%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636758301470504508&sdata=nTiT5UpHuH5h9EkAhz%2Fby3TVPw%2FanzRAZsdnRLlKH5U%3D&reserved=0 Is it possible - at our own risk - to install it on the latest preview bits?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Froslyn%2Fissues%2F29987%23issuecomment-431928138&data=02%7C01%7Cjcouv%40microsoft.com%7C60fec87481f343c5707008d6384d2ded%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636758301470504508&sdata=UWwwoOhPUnbZRr3axQ3gUEcHditXZbEHFJ5IZuQignk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAL44OXlqnzGcx7uA31Vfy4V_bPgWxrBXks5unhAAgaJpZM4WtAjr&data=02%7C01%7Cjcouv%40microsoft.com%7C60fec87481f343c5707008d6384d2ded%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636758301470514517&sdata=8Lw705xjem0p2iifmikSCQ%2BxQuULzjIFkvjhyyPN4p0%3D&reserved=0.

[pellea]

@jcouv I have the 15.9 preview 3 like @Craigfis. I don't really want to downgrade VS (I don't even know if that is possible).

[chucker]

@pellea VS Preview installs side-by-side with VS regular. Thus, installing 15.8.6 won't be a downgrade; your 15.9 Preview 3 installation will remain.

[pellea]

@chucker I never installed the regular version. I have only the preview. If there is no possibilities to get this to work with the preview version, I'll then install the regular version.

[chucker]

@pellea Yup. It's not currently compatible with the 15.9 preview. You'll need to install the regular 15.8.x on the side to test this.