Roslyn: Make Readonly doesn't have a description for the Error List

Created on 18 Apr 2018  路  8Comments  路  Source: dotnet/roslyn

image

It shows Description as blank for IDE0044.

Area-IDE Bug Developer Community Resolution-Fixed Tenet-Localization

Most helpful comment

Looks like we're using incorrect resources here:

c# new LocalizableResourceString(nameof(FeaturesResources.Add_readonly_modifier), FeaturesResources.ResourceManager, typeof(FeaturesResources)), new LocalizableResourceString(nameof(FeaturesResources.Make_field_readonly), WorkspacesResources.ResourceManager, typeof(WorkspacesResources)))

Note the use of WorkspacesResources. @mavasani Something to consider for an anlayzer.

All 8 comments

Looks like we're using incorrect resources here:

c# new LocalizableResourceString(nameof(FeaturesResources.Add_readonly_modifier), FeaturesResources.ResourceManager, typeof(FeaturesResources)), new LocalizableResourceString(nameof(FeaturesResources.Make_field_readonly), WorkspacesResources.ResourceManager, typeof(WorkspacesResources)))

Note the use of WorkspacesResources. @mavasani Something to consider for an anlayzer.

also reported at link , link

Why has this been closed?? I haven't seen a description in the error list for IDE0044, ever.

Is there a fix / mod to add the description in? Again, why has this been closed?!?!

@grimreaper38uk because @sharwell fixed the line of code which was causing this issue. With the issue fixed, the issue is closed. We normally do not keep bugs open until the fixes are released. Perhaps the "closed" state should say "Fixed in Next Release" like we do on DeveloperCommunity.VisualStudio.com, but I do not know if that is even an option on GitHub or not.

I try to use the Milestone to indicate when the fix is expected to appear (15.8 for this bug). Not everyone uses that field though so it may be missing or stale in cases.

Oh, I understand. So correcting one line of code requires a 4 month wait for a major build release, despite there being several minor releases in the interim. Makes perfect sense.
I look forward to 15.8 being released with baited breath, once Christmas is out of the way, obviously.

Thanks to the Roslyn team for getting this fixed!

@grimreaper38uk I'm seeing 15.8 preview 5 publicly available now.

image

https://visualstudio.com/vs/preview

Was this page helpful?
0 / 5 - 0 ratings