Roslyn: Enable Rename file to match class name feature for .Net Core projects

[jinujoseph]

context https://github.com/dotnet/roslyn/issues/16546
cc @davkean , not sure if this belongs to project system or here.

[ErikSchierboom]

This would be great!

[igsbr]

This feature is also disabled for classic .Net Framework projects with the new SDK style .csproj file format.

[davkean]

@igsbr For those projects, do they have a References node or a Dependencies node?

[igsbr]

VS2017 shows Dependencies node in Solution Explorer for new SDK style projects and References node for old style projects.

[davkean]

Yeah I was just trying to see which project system you were using, both are using the new project system - and hence the bug.

[igsbr]

As I know, the new SDK style .csproj is differ. I mean, it contains something like this:

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net461</TargetFramework>
  </PropertyGroup>
</Project>

But, if you create a clean .Net Framework project in VS2017, you'll end up with the much more verbose .csporj file (old style):

<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
  <PropertyGroup>
...
... 
...

[davkean]

Yes that's correct.

You stated:

This feature is also disabled for classic .Net Framework projects with the new SDK style .csproj file format.

What I meant above, is that this project is also using the new project system (http://github.com/dotnet/project-system), and hence the same underlying bug.

[igsbr]

In the my first statement I just wanted to point out, that this issue is possibly related not only to .Net Core projects. So, I totally agree with your last statement.

[davkean]

👍

[quetzalcoatl]

We're still missing that feature :( I know that's not a critical one, but are there any plans for patching it up and reenabling?